phpstan

Author: sreichel

.phpstan.dist.baseline.neon

@@ -5329,7 +5329,7 @@ parameters:
 			path: app/code/core/Mage/ImportExport/Model/Resource/Helper/Mysql4.php
 
 		-
-			rawMessage: 'Method Mage_ImportExport_Model_Resource_Import_Data::getIterator() should return IteratorIterator but returns Traversable<mixed, mixed>.'
+			rawMessage: 'Method Mage_ImportExport_Model_Resource_Import_Data::getIterator() should return Iterator but returns Traversable<mixed, mixed>.'
 			identifier: return.type
 			count: 1
 			path: app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php

app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging/Grid.php

@@ -23,7 +23,8 @@ public function __construct()
     /**
      * Return collection of shipment items
      *
-     * @return array
+     * @return iterable<Mage_Sales_Model_Order_Shipment_Item>
+     * @throws Mage_Core_Exception
      */
     public function getCollection()
     {

app/code/core/Mage/Eav/Model/Attribute/Data/Multiline.php

@@ -17,7 +17,7 @@ class Mage_Eav_Model_Attribute_Data_Multiline extends Mage_Eav_Model_Attribute_D
     /**
      * Extract data from request and return value
      *
-     * @return array|string
+     * @return array|false
      */
     public function extractValue(Zend_Controller_Request_Http $request)
     {

app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php

@@ -15,7 +15,7 @@
 class Mage_ImportExport_Model_Resource_Import_Data extends Mage_Core_Model_Resource_Db_Abstract implements IteratorAggregate
 {
     /**
-     * @var null|IteratorIterator
+     * @var null|Iterator
      */
     protected $_iterator = null;
 
@@ -30,7 +30,11 @@ protected function _construct()
     /**
      * Retrieve an external iterator
      *
-     * @return array|ArrayIterator|Iterator|Traversable
+     * @return ArrayIterator|Iterator
+     * @throws Exception
+     * @throws Mage_Core_Exception
+     * @throws Zend_Db_Adapter_Exception
+     * @throws Zend_Db_Statement_Exception
      */
     #[\ReturnTypeWillChange]
     public function getIterator()
@@ -56,6 +60,7 @@ public function getIterator()
      * Clean all bunches from table.
      *
      * @return int
+     * @throws Mage_Core_Exception
      */
     public function cleanBunches()
     {
@@ -106,6 +111,8 @@ public function getEntityTypeCode()
      * Get next bunch of validated rows.
      *
      * @return null|array
+     * @throws Zend_Db_Statement_Exception
+     * @throws Zend_Json_Exception
      */
     public function getNextBunch()
     {
@@ -129,9 +136,11 @@ public function getNextBunch()
     /**
      * Save import rows bunch.
      *
-     * @param  string $entity
-     * @param  string $behavior
+     * @param  string                    $entity
+     * @param  string                    $behavior
      * @return int
+     * @throws Mage_Core_Exception
+     * @throws Zend_Db_Adapter_Exception
      */
     public function saveBunch($entity, $behavior, array $data)
     {

app/code/core/Mage/Sales/Model/Order/Shipment.php

@@ -264,8 +264,8 @@ public function getAllItems()
     }
 
     /**
-     * @param  int  $itemId
-     * @return bool
+     * @param  int                                        $itemId
+     * @return false|Mage_Sales_Model_Order_Shipment_Item
      */
     public function getItemById($itemId)
     {

app/code/core/Mage/Sales/Model/Resource/Order/Shipment/Item/Collection.php

@@ -12,8 +12,9 @@
  *
  * @package    Mage_Sales
  *
- * @method Mage_Sales_Model_Order_Shipment_Item   getItemById(int $value)
- * @method Mage_Sales_Model_Order_Shipment_Item[] getItems()
+ * @method Mage_Sales_Model_Order_Shipment_Item           getItemById(int $value)
+ * @method Mage_Sales_Model_Order_Shipment_Item[]         getItems()
+ * @method iterable<Mage_Sales_Model_Order_Shipment_Item> getIterator()
  */
 class Mage_Sales_Model_Resource_Order_Shipment_Item_Collection extends Mage_Sales_Model_Resource_Collection_Abstract
 {