Fix: Stripe checkout 400, PWA icon 404, and dynamic price ID resolution

- Fix _get_or_create_customer selecting non-existent email column from
  user_profiles — was silently returning None causing 502 on checkout
- Fix success/cancel URLs to use FRONTEND_URL env var (default localhost:3000)
  and match the query params the billing page already expects (?success=true)
- Build PRICE_TO_PLAN dynamically from configured Stripe env vars so
  webhook-triggered plan upgrades work with real price IDs
- Add FRONTEND_URL setting to config
- Frontend now reads price IDs from NEXT_PUBLIC_STRIPE_*_PRICE_ID env vars
  and passes them directly as price_id to bypass backend env var resolution
- billingApi.createCheckoutSession accepts optional priceId param
- Show descriptive error if Stripe is not configured rather than generic toast
- Add icon-192.png and icon-512.png to fix PWA manifest 404 errors

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

backend/config.py

@@ -66,6 +66,9 @@ def agency_monthly_price_id(self) -> str:
     def agency_yearly_price_id(self) -> str:
         return self.STRIPE_PRICE_AGENCY_YEARLY or self.STRIPE_AGENCY_PRICE_ID
 
+    # Frontend base URL (used for Stripe redirect URLs)
+    FRONTEND_URL: str = "http://localhost:3000"
+
     # JWT / Auth
     SECRET_KEY: str
     ALGORITHM: str = "HS256"

backend/routes/billing.py

@@ -53,6 +53,12 @@ async def create_checkout(
         price_id = plan_to_price.get(body.plan_id, {}).get(body.interval, "")
 
     if not price_id:
+        logger.error(
+            "Checkout failed: no price_id resolved. plan_id=%s interval=%s — "
+            "set STRIPE_PRO_PRICE_ID / STRIPE_AGENCY_PRICE_ID in backend .env",
+            body.plan_id,
+            body.interval,
+        )
         raise HTTPException(
             status_code=status.HTTP_400_BAD_REQUEST,
             detail="No valid price_id or plan_id provided.",

backend/services/stripe_service.py

@@ -7,12 +7,26 @@
 
 stripe.api_key = settings.STRIPE_SECRET_KEY
 
-# Map Stripe price IDs to plan names (override in .env / config as needed)
-PRICE_TO_PLAN: dict[str, str] = {
-    "price_pro_monthly": "pro",
-    "price_pro_annual": "pro",
-    "price_enterprise_monthly": "enterprise",
-}
+def _build_price_to_plan() -> dict[str, str]:
+    """Build the price ID → plan name map from configured env vars."""
+    mapping: dict[str, str] = {}
+    for price_id in (
+        settings.STRIPE_PRO_PRICE_ID,
+        settings.STRIPE_PRICE_PRO_MONTHLY,
+        settings.STRIPE_PRICE_PRO_YEARLY,
+    ):
+        if price_id:
+            mapping[price_id] = "pro"
+    for price_id in (
+        settings.STRIPE_AGENCY_PRICE_ID,
+        settings.STRIPE_PRICE_AGENCY_MONTHLY,
+        settings.STRIPE_PRICE_AGENCY_YEARLY,
+    ):
+        if price_id:
+            mapping[price_id] = "agency"
+    return mapping
+
+PRICE_TO_PLAN: dict[str, str] = _build_price_to_plan()
 
 
 # ---------------------------------------------------------------------------
@@ -49,7 +63,7 @@ async def _get_or_create_customer(user_id: str, email: str) -> str | None:
         supabase = get_supabase()
         result = (
             supabase.table("user_profiles")
-            .select("stripe_customer_id, email")
+            .select("stripe_customer_id")
             .eq("id", user_id)
             .single()
             .execute()
@@ -58,9 +72,7 @@ async def _get_or_create_customer(user_id: str, email: str) -> str | None:
         existing = profile.get("stripe_customer_id")
         if existing:
             return existing
-        # Use provided email or fall back to stored email
-        resolved_email = email or profile.get("email", "")
-        return await create_customer(user_id, resolved_email)
+        return await create_customer(user_id, email)
     except Exception as exc:
         logger.error(
             "_get_or_create_customer error (user_id=%s): %s", user_id, exc
@@ -84,13 +96,14 @@ async def create_checkout_session(
         if not customer_id:
             return None
 
+        frontend_url = settings.FRONTEND_URL.rstrip("/") if hasattr(settings, "FRONTEND_URL") and settings.FRONTEND_URL else "http://localhost:3000"
         session = stripe.checkout.Session.create(
             customer=customer_id,
             payment_method_types=["card"],
             line_items=[{"price": price_id, "quantity": 1}],
             mode="subscription",
-            success_url="https://inboxiq.app/billing/success?session_id={CHECKOUT_SESSION_ID}",
-            cancel_url="https://inboxiq.app/billing/cancel",
+            success_url=f"{frontend_url}/billing?success=true&session_id={{CHECKOUT_SESSION_ID}}",
+            cancel_url=f"{frontend_url}/billing?canceled=true",
             metadata={"user_id": user_id},
         )
         return session.url

frontend/.env.local.example

@@ -2,3 +2,5 @@ NEXT_PUBLIC_SUPABASE_URL=your_supabase_url
 NEXT_PUBLIC_SUPABASE_ANON_KEY=your_supabase_anon_key
 NEXT_PUBLIC_API_URL=http://localhost:8000
 NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=pk_test_your_key
+NEXT_PUBLIC_STRIPE_PRO_PRICE_ID=price_your_pro_price_id
+NEXT_PUBLIC_STRIPE_AGENCY_PRICE_ID=price_your_agency_price_id

frontend/lib/api.ts

@@ -366,11 +366,13 @@ export const billingApi = {
 
   createCheckoutSession: async (
     planId: string,
-    interval: 'monthly' | 'yearly' = 'monthly'
+    interval: 'monthly' | 'yearly' = 'monthly',
+    priceId?: string
   ): Promise<{ checkout_url: string }> => {
     const { data } = await api.post('/api/billing/checkout', {
       plan_id: planId,
       interval,
+      ...(priceId ? { price_id: priceId } : {}),
     });
     return data;
   },

frontend/pages/billing/index.tsx

@@ -50,7 +50,7 @@ const PLANS: Plan[] = [
       'Slack notifications',
       'Priority support',
     ],
-    stripe_price_id: 'price_pro_monthly',
+    stripe_price_id: process.env.NEXT_PUBLIC_STRIPE_PRO_PRICE_ID || '',
   },
   {
     id: 'agency',
@@ -66,7 +66,7 @@ const PLANS: Plan[] = [
       'API access',
       'Dedicated support',
     ],
-    stripe_price_id: 'price_agency_monthly',
+    stripe_price_id: process.env.NEXT_PUBLIC_STRIPE_AGENCY_PRICE_ID || '',
   },
 ];
 
@@ -111,10 +111,18 @@ export default function BillingPage() {
     if (planId === 'free') return;
     setLoadingPlan(planId);
     try {
-      const { checkout_url } = await billingApi.createCheckoutSession(planId);
+      const plan = PLANS.find((p) => p.id === planId);
+      const priceId = plan?.stripe_price_id || undefined;
+      const { checkout_url } = await billingApi.createCheckoutSession(planId, 'monthly', priceId);
       window.location.href = checkout_url;
-    } catch {
-      toast.error('Failed to start checkout. Please try again.');
+    } catch (err: unknown) {
+      const msg =
+        (err as { response?: { data?: { detail?: string } } })?.response?.data?.detail;
+      toast.error(
+        msg === 'No valid price_id or plan_id provided.'
+          ? 'Stripe is not configured. Set STRIPE_PRO_PRICE_ID / STRIPE_AGENCY_PRICE_ID in your backend .env.'
+          : 'Failed to start checkout. Please try again.'
+      );
       setLoadingPlan(null);
     }
   };