Merge pull request #87 from srobo/static-links

Static links

Author: RealOrangeOne

helpdesk/core/templatetags/navigation.py

@@ -1,10 +1,21 @@
+import operator
+
 from django.template import Library, RequestContext
 
 from core.models import NavigationLink
 
 register = Library()
 
+# Some links are so universal, it's easier to hardcode them.
+STATIC_LINKS = [
+    NavigationLink("Competition details", "https://srobo.org/comp"),
+    NavigationLink("Docs", "https://srobo.org/docs"),
+    NavigationLink("Rules", "https://srobo.org/rules"),
+    NavigationLink("Runbook", "https://srobo.org/runbook/"),
+]
+
 
 @register.inclusion_tag("tags/navigation.html", takes_context=True)
 def navigation(context: RequestContext) -> dict:
-    return {**context.flatten(), "links": NavigationLink.objects.all()}
+    links = sorted(list(NavigationLink.objects.all()) + STATIC_LINKS, key=operator.attrgetter("name"))
+    return {**context.flatten(), "links": links}

helpdesk/helpdesk/tests/test_smoke.py

@@ -19,3 +19,9 @@ def test_landing_page_redirects(client: Client, admin_user: User) -> None:
     resp = client.get("/")
     assert resp.status_code == 302
     assert resp["Location"] == "/accounts/onboarding/"
+
+
+def test_onboarding(client: Client, admin_user: User) -> None:
+    client.force_login(admin_user)
+    resp = client.get("/accounts/onboarding/")
+    assert resp.status_code == 200

helpdesk/templates/tags/navigation.html

@@ -36,19 +36,17 @@
         </a>
       {% endif %}
 
-      {% if links %}
-        <div class="navbar-item has-dropdown is-hoverable">
-          <a class="navbar-link">
-            Links
-          </a>
+      <div class="navbar-item has-dropdown is-hoverable">
+        <a class="navbar-link">
+          Links
+        </a>
 
-          <div class="navbar-dropdown">
-            {% for link in links %}
-              <a class="navbar-item" href="{{ link.url }}">{{ link.name }}</a>
-            {% endfor %}
-          </div>
+        <div class="navbar-dropdown">
+          {% for link in links %}
+            <a class="navbar-item" href="{{ link.url }}">{{ link.name }}</a>
+          {% endfor %}
         </div>
-      {% endif %}
+      </div>
 
       {% if user.is_authenticated %}
         <div class="navbar-item has-dropdown is-hoverable">