From f7aa6594a3f383ac9986170dd4d6e131f04a11b5 Mon Sep 17 00:00:00 2001 From: Peter Law Date: Thu, 27 Jan 2022 00:17:15 +0000 Subject: [PATCH] Print for all rate limit errors Not just the ones that we're intercepting and converting. --- scripts/import_backends.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/import_backends.py b/scripts/import_backends.py index a311741..816fe75 100644 --- a/scripts/import_backends.py +++ b/scripts/import_backends.py @@ -229,7 +229,10 @@ def submit(self, ticket: Ticket) -> int: # limit us anyway... def retry_on_exception(exception: Exception) -> bool: - return isinstance(exception, github.RateLimitExceededException) + if isinstance(exception, github.RateLimitExceededException): + print("... GitHub Rate Limited ...") + return True + return False @retrying.retry( retry_on_exception=retry_on_exception, @@ -251,7 +254,6 @@ def create_issue() -> github.Issue.Issue: isinstance(message, str) and RATE_LIMIT_MESSAGE in message ): - print("... GitHub Rate Limited ...") raise github.RateLimitExceededException( status=e.status, data=e.data,