Skip to content

Conversation

@matan1008
Copy link
Contributor

Tested over zmq.
Thanks a lot!

@andrepuschmann
Copy link
Collaborator

Thanks @matan1008 for the contribution. Unfortunately we didn't have the bandwidth to review and integrate this before the 21.10 release. However, I encourage you to rebase the branch again on current master so we can consider it again. I
apologize for this.

@matan1008 matan1008 force-pushed the feature/pcap-net-ue branch from 69b8d9c to c4b1ee5 Compare October 29, 2021 11:55
Copy link
Collaborator

@andrepuschmann andrepuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. Could you check the SCTP thing please.

# and at http://www.gnu.org/licenses/.
#

find_package(SCTP REQUIRED)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed for the UE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know why it is required (maybe to send the capture over the network?) but without linking with SCTP the build fails with:

[ 78%] Linking CXX executable srsue
/usr/bin/ld: ../../lib/src/common/libsrsran_common.a(network_utils.cc.o): in function `srsran::task_details::heap_table_t<srsran::sctp_recvmsg_pdu_task, bool, int>::call(void*, int) const':
network_utils.cc:(.text._ZNK6srsran12task_details12heap_table_tINS_21sctp_recvmsg_pdu_taskEbJiEE4callEPvi[_ZNK6srsran12task_details12heap_table_tINS_21sctp_recvmsg_pdu_taskEbJiEE4callEPvi]+0xe6): undefined reference to `sctp_recvmsg'
collect2: error: ld returned 1 exit status
make[2]: *** [srsue/src/CMakeFiles/srsue.dir/build.make:181: srsue/src/srsue] Error 1
make[1]: *** [CMakeFiles/Makefile2:10845: srsue/src/CMakeFiles/srsue.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh, maybe the network utils need to be stripped to have a version without SCTP that can be used in srsUE. I have to say that we are reluctant to do this change now. I'd leave the PR open in case it's useful for others like it is.

${Boost_LIBRARIES}
${ATOMIC_LIBS})
${ATOMIC_LIBS}
${SCTP_LIBRARIES})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be needed for the UE

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants