The Everlasting Promised Reagent Fire at the End of the Horizon #22776
Annotations
2 errors and 21 warnings
|
Report C# diagnostics on changed lines
Process completed with exit code 1.
|
|
Report C# diagnostics on changed lines
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
|
Complete job
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: space-wizards/submodule-dependency@v0.1.5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Starlight/Medical/Body/Systems/SharedBloodstreamSystem.cs#L128
[C# diagnostics] reported by reviewdog 🐶
'SharedSolutionContainerSystem.EnsureSolution(Entity<SolutionManagerComponent?>, string, out Entity<SolutionComponent>)' is obsolete: 'Solution string matching will be removed in the future in favor of relations and enumerators.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Starlight/Medical/Body/Systems/SharedBloodstreamSystem.cs"},"region":{"endColumn":117,"endLine":128,"startColumn":9,"startLine":128}}}],"message":{"text":"'SharedSolutionContainerSystem.EnsureSolution(Entity\u003cSolutionManagerComponent?\u003e, string, out Entity\u003cSolutionComponent\u003e)' is obsolete: 'Solution string matching will be removed in the future in favor of relations and enumerators.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Starlight/Medical/Body/Systems/SharedBloodstreamSystem.cs#L127
[C# diagnostics] reported by reviewdog 🐶
'SharedSolutionContainerSystem.EnsureSolution(Entity<SolutionManagerComponent?>, string, out Entity<SolutionComponent>)' is obsolete: 'Solution string matching will be removed in the future in favor of relations and enumerators.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Starlight/Medical/Body/Systems/SharedBloodstreamSystem.cs"},"region":{"endColumn":109,"endLine":127,"startColumn":9,"startLine":127}}}],"message":{"text":"'SharedSolutionContainerSystem.EnsureSolution(Entity\u003cSolutionManagerComponent?\u003e, string, out Entity\u003cSolutionComponent\u003e)' is obsolete: 'Solution string matching will be removed in the future in favor of relations and enumerators.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/Medical/Healing/HealingSystem.cs#L127
[C# diagnostics] reported by reviewdog 🐶
The result of the expression is always 'true' since a value of type 'ReagentQuantity' is never equal to 'null' of type 'ReagentQuantity?'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/Medical/Healing/HealingSystem.cs"},"region":{"endColumn":41,"endLine":127,"startColumn":21,"startLine":127}}}],"message":{"text":"The result of the expression is always 'true' since a value of type 'ReagentQuantity' is never equal to 'null' of type 'ReagentQuantity?'"},"properties":{},"ruleId":"CS8073","ruleIndex":506}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Funkystation/Footprints/FootprintSystem.cs#L285
[C# diagnostics] reported by reviewdog 🐶
'SharedMapSystem.GetAnchoredEntitiesEnumerator(EntityUid, MapGridComponent, Vector2i)' is obsolete: 'Use GetAnchoredEntities instead.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Funkystation/Footprints/FootprintSystem.cs"},"region":{"endColumn":81,"endLine":285,"startColumn":26,"startLine":285}}}],"message":{"text":"'SharedMapSystem.GetAnchoredEntitiesEnumerator(EntityUid, MapGridComponent, Vector2i)' is obsolete: 'Use GetAnchoredEntities instead.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Funkystation/Footprints/FootprintSystem.cs#L265
[C# diagnostics] reported by reviewdog 🐶
'SharedMapSystem.GetAnchoredEntitiesEnumerator(EntityUid, MapGridComponent, Vector2i)' is obsolete: 'Use GetAnchoredEntities instead.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Funkystation/Footprints/FootprintSystem.cs"},"region":{"endColumn":81,"endLine":265,"startColumn":26,"startLine":265}}}],"message":{"text":"'SharedMapSystem.GetAnchoredEntitiesEnumerator(EntityUid, MapGridComponent, Vector2i)' is obsolete: 'Use GetAnchoredEntities instead.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Funkystation/Footprints/FootprintSystem.cs#L212
[C# diagnostics] reported by reviewdog 🐶
'RandomExtensions.Pick<T>(Random, ICollection<T>)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Funkystation/Footprints/FootprintSystem.cs"},"region":{"endColumn":66,"endLine":212,"startColumn":43,"startLine":212}}}],"message":{"text":"'RandomExtensions.Pick\u003cT\u003e(Random, ICollection\u003cT\u003e)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Funkystation/Stains/Systems/SharedStainSystem.cs#L69
[C# diagnostics] reported by reviewdog 🐶
'RandomHelpers.Prob(Random, double)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Funkystation/Stains/Systems/SharedStainSystem.cs"},"region":{"endColumn":45,"endLine":69,"startColumn":14,"startLine":69}}}],"message":{"text":"'RandomHelpers.Prob(Random, double)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Funkystation/WashingMachine/SharedWashingMachineSystem.cs#L170
[C# diagnostics] reported by reviewdog 🐶
'RandomHelpers.Prob(Random, double)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Funkystation/WashingMachine/SharedWashingMachineSystem.cs"},"region":{"endColumn":61,"endLine":170,"startColumn":17,"startLine":170}}}],"message":{"text":"'RandomHelpers.Prob(Random, double)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/_Funkystation/WashingMachine/SharedWashingMachineSystem.cs#L153
[C# diagnostics] reported by reviewdog 🐶
'RandomHelpers.Prob(Random, double)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/_Funkystation/WashingMachine/SharedWashingMachineSystem.cs"},"region":{"endColumn":70,"endLine":153,"startColumn":26,"startLine":153}}}],"message":{"text":"'RandomHelpers.Prob(Random, double)' is obsolete: 'Always use RobustRandom/IRobustRandom, System.Random does not provide any extra functionality.'"},"properties":{},"ruleId":"CS0618","ruleIndex":501}
|
|
Report C# diagnostics on changed lines:
Content.Shared/Chemistry/EntitySystems/SharedSolutionContainerSystem.Compatibility.cs#L20
[C# diagnostics] reported by reviewdog 🐶
'SolutionContainerManagerComponent' is obsolete
Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/space-station-14/space-station-14/Content.Shared/Chemistry/EntitySystems/SharedSolutionContainerSystem.Compatibility.cs"},"region":{"endColumn":82,"endLine":20,"startColumn":49,"startLine":20}}}],"message":{"text":"'SolutionContainerManagerComponent' is obsolete"},"properties":{},"ruleId":"CS0612","ruleIndex":503}
|
|
Build Project and collect C# diagnostics:
Content.Server.Database/SnakeCaseNaming.cs#L13
Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
|
|
Build Project and collect C# diagnostics:
Content.Server.Database/ModelSqlite.cs#L14
Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
|
|
Build Project and collect C# diagnostics:
Content.Server.Database/ModelPostgres.cs#L9
Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
|
|
Build Project and collect C# diagnostics:
Content.Server.Database/Model.cs#L14
Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
|
|
Build Project and collect C# diagnostics:
Content.Server.Database/DataModelBase.cs#L13
Consecutive braces must not have blank line between them (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide2002)
|
|
Build Project and collect C# diagnostics:
Content.Server.Database/DataModelBase.cs#L36
Consecutive braces must not have blank line between them (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide2002)
|
|
Build Project and collect C# diagnostics:
Content.Shared.Database/TypedHwid.cs#L46
Use expression body for method (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0022)
|
|
Build Project and collect C# diagnostics:
Content.Shared.Database/TypedHwid.cs#L46
Parentheses should be added for clarity (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0048)
|
|
Build Project and collect C# diagnostics:
Content.Shared.Database/NoteSeverity.cs#L1
Convert to file-scoped namespace (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0161)
|
|
Build Project and collect C# diagnostics:
Content.PatreonParser/Program.cs#L83
Use pattern matching (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0078)
|
background
wait
wait-all
cancel
parallel
Loading