Fix more things that shouldn't be antags from rolling antags (#5878)

## Short description
Cheese you're going to be the death of me.

## Why we need to add this
pAIs cannot do objectives.

## Checks
- [X] I do not require assistance to complete the PR.
- [X] Before posting/requesting review of a PR, I have verified that the
changes work.
- [X] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [X] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

**Changelog**
:cl: wonderfulnewworld
- fix: pAIs/clothes/trunks can no longer roll antags.
- fix: Terror Spiders, Xenoborgs, and some other things are no longer
crew aligned.

Author: wonderfulnewworld

Content.Server/Antag/AntagSelectionSystem.API.Assignment.cs

@@ -210,7 +210,7 @@ public bool IsEntityValid(ICommonSession session, AntagSpecifierPrototype def)
     }
 
     /// <inhereitdoc cref="IsEntityValid(EntityUid?,AntagSpecifierPrototype)"/>
-    public bool IsEntityValid([NotNullWhen(true)] EntityUid? uid, ProtoId<AntagSpecifierPrototype> def)
+    public bool IsEntityValid(EntityUid? uid, ProtoId<AntagSpecifierPrototype> def) // Starlight
     {
         if (!Proto.Resolve(def, out var antag))
             return false;
@@ -225,7 +225,7 @@ public bool IsEntityValid([NotNullWhen(true)] EntityUid? uid, ProtoId<AntagSpeci
     /// <param name="uid">Entity whose validity we're checking.</param>
     /// <param name="def">Antag definition we want to give them.</param>
     /// <returns>True if there is nothing stopping this entity from being this antag. Or if there is no entity.</returns>
-    public bool IsEntityValid([NotNullWhen(true)] EntityUid? uid, AntagSpecifierPrototype def)
+    public bool IsEntityValid(EntityUid? uid, AntagSpecifierPrototype def) // Starlight
     {
         // If the player has not spawned in as any entity (e.g., in the lobby), they can be given an antag role/entity.
         if (!_whitelist.CheckBoth(uid, def.Blacklist, def.Whitelist))
@@ -239,7 +239,7 @@ public bool IsEntityValid([NotNullWhen(true)] EntityUid? uid, AntagSpecifierProt
         if (HasComp<GhostComponent>(uid))
             return false;
 
-        if (!def.AllowNonHumans && !HasComp<HumanoidAppearanceComponent>(uid) && !HasComp<HandsComponent>(uid)) // Starlight, no visual nubody
+        if (!HasComp<HumanoidAppearanceComponent>(uid) && (!def.AllowNonHumans || !HasComp<HandsComponent>(uid))) // Starlight, Cheese, you have sent me down the path of the hell trying to get this working reliably
             return false;
 
         return true;

Resources/Prototypes/Entities/Mobs/Player/guardian.yml

@@ -113,6 +113,7 @@
         - CannotSuicide
         - StunImmune
         - SlowImmune
+    - type: AntagImmune # Starlight
 
 # From the uplink injector
 - type: entity

Resources/Prototypes/Entities/Mobs/Player/silicon.yml

@@ -647,6 +647,7 @@
       name: ghost-role-information-syndicate-cyborg-assault-name
       description: ghost-role-information-syndicate-cyborg-description
       rules: ghost-role-information-silicon-rules
+      mindRoles: [MindRoleGhostRoleSiliconAntagonist] # Starlight
       important: true # SL
       raffle:
         settings: default
@@ -700,6 +701,7 @@
       name: ghost-role-information-syndicate-cyborg-saboteur-name
       description: ghost-role-information-syndicate-cyborg-description
       rules: ghost-role-information-silicon-rules
+      mindRoles: [MindRoleGhostRoleSiliconAntagonist] # Starlight
       important: true # SL
       raffle:
         settings: default
@@ -761,6 +763,7 @@
     name: ghost-role-information-derelict-engineering-cyborg-name
     description: ghost-role-information-derelict-engineering-cyborg-description
     rules: ghost-role-information-silicon-rules
+    mindRoles: [MindRoleSubvertedSilicon] # Starlight
     raffle:
       settings: default
     reregister: false
@@ -802,6 +805,7 @@
       name: ghost-role-information-derelict-cyborg-name
       description: ghost-role-information-derelict-cyborg-description
       rules: ghost-role-information-silicon-rules
+      mindRoles: [MindRoleSubvertedSilicon] # Starlight
       raffle:
         settings: default
       reregister: false
@@ -845,6 +849,7 @@
     name: ghost-role-information-derelict-janitor-cyborg-name
     description: ghost-role-information-derelict-janitor-cyborg-description
     rules: ghost-role-information-silicon-rules
+    mindRoles: [MindRoleSubvertedSilicon] # Starlight
     raffle:
       settings: default
     reregister: false
@@ -889,6 +894,7 @@
     name: ghost-role-information-derelict-medical-cyborg-name
     description: ghost-role-information-derelict-medical-cyborg-description
     rules: ghost-role-information-silicon-rules
+    mindRoles: [MindRoleSubvertedSilicon] # Starlight
     raffle:
       settings: default
     reregister: false
@@ -932,6 +938,7 @@
     name: ghost-role-information-derelict-mining-cyborg-name
     description: ghost-role-information-derelict-mining-cyborg-description
     rules: ghost-role-information-silicon-rules
+    mindRoles: [MindRoleSubvertedSilicon] # Starlight
     raffle:
       settings: default
     reregister: false
@@ -974,6 +981,7 @@
     name: ghost-role-information-derelict-syndicate-assault-cyborg-name
     description: ghost-role-information-derelict-syndicate-assault-cyborg-description
     rules: ghost-role-information-silicon-rules
+    mindRoles: [MindRoleSubvertedSilicon] # Starlight
     raffle:
       settings: default
     reregister: false

Resources/Prototypes/Entities/Objects/Devices/Syndicate_Gadgets/reinforcement_teleporter.yml

@@ -117,7 +117,7 @@
       rules: ghost-role-information-silicon-rules
       important: true # SL
       mindRoles:
-      - MindRoleGhostRoleSilicon
+      - MindRoleGhostRoleSiliconAntagonist # Starlight
       raffle:
         settings: default
       job: Borg

Resources/Prototypes/Entities/Objects/Fun/pai.yml

@@ -121,6 +121,7 @@
   - type: Blindable
   - type: ParentCanBlockVision
   - type: ContentEye
+  - type: AntagImmune
   # Starlight End
 
 - type: entity

Resources/Prototypes/_Starlight/Entities/Clothing/Back/trunks.yml

@@ -90,4 +90,5 @@
     baseSprintSpeed: 0
   - type: TextToSpeech
     voice: karma
+  - type: AntagImmune
 # Fashion-O-Mat END

Resources/Prototypes/_Starlight/Entities/Clothing/Neck/cloaks.yml

@@ -300,6 +300,7 @@
     sprite: _Starlight/Clothing/Neck/Ties/disco.rsi
   - type: Clothing
     sprite: _Starlight/Clothing/Neck/Ties/disco.rsi
+  - type: AntagImmune
 
 - type: entity
   parent: ClothingNeckBase

Resources/Prototypes/_Starlight/Entities/Markers/Spawners/ghost_roles.yml

@@ -7,8 +7,7 @@
     name: ghost-role-information-derelict-borgi-name
     description: ghost-role-information-derelict-borgi-desc
     rules: ghost-role-information-silicon-rules
-    mindRoles:
-    - MindRoleSubvertedSilicon
+    mindRoles: [MindRoleSubvertedSilicon]
     raffle:
       settings: default
   - type: Sprite
@@ -29,8 +28,7 @@
     important: true
     name: roles-antag-brighteye-name
     description: roles-antag-brighteye-description
-    mindRoles:
-    - MindRoleBrighteye
+    mindRoles: [MindRoleBrighteye]
     raffle:
       settings: default
   - type: Sprite
@@ -51,8 +49,7 @@
     name: ghost-role-information-terminator-name
     description: ghost-role-information-terminator-description
     rules: ghost-role-information-terminator-rules
-    mindRoles:
-    - MindRoleTerminator
+    mindRoles: [MindRoleTerminator]
     raffle:
       settings: default
   - type: Sprite
@@ -143,8 +140,7 @@
     description: ghost-role-information-terror-princess-description
     rules: ghost-role-information-rules-team-antagonist
     important: true
-    mindRoles:
-    - MindRoleTerrorPrincess
+    mindRoles: [MindRoleTerrorPrincess]
   - type: Sprite
     layers:
     - state: green
@@ -161,8 +157,7 @@
     name: ghost-role-information-xenoroach-name
     description: ghost-role-information-xenoroach-description
     rules: ghost-role-information-silicon-rules
-    mindRoles:
-    - MindRoleXenoborg
+    mindRoles: [MindRoleXenoborg]
     raffle:
       settings: default
   - type: GhostRoleMobSpawner
@@ -184,6 +179,7 @@
     name: Cluwne Beast
     description: Spread laughter and chaos by hitting and turning the crew into cluwnes.
     rules: You are an antagonist, transform as many of the crew as you can into cluwnes.
+    mindRoles: [MindRoleGhostRoleSoloAntagonist]
   - type: GhostRoleMobSpawner
     prototype: MobCluwneBeast
   - type: Sprite

Resources/Prototypes/_Starlight/Entities/Mobs/Cyborgs/base_borgi_chassis.yml

@@ -250,6 +250,7 @@
       name: A Syndicate Borgi.
       description: The Syndicate needs reinforcements. You, a cold, BUT LOVINGLY ADORABLE, silicon killing machine, will help them... And bork.  An unusual choice, but it was made nonetheless.
       rules: ghost-role-information-silicon-rules
+      mindRoles: [MindRoleGhostRoleSiliconAntagonist]
       important: true # SL
       raffle:
         settings: default

Resources/Prototypes/_Starlight/Entities/Mobs/Cyborgs/borgi_chassis.yml

@@ -278,6 +278,7 @@
       name: XenoBorgi
       description: Your job is to assist the mothership with their duties with your pair of hands. You of inferior flesh have a job to do.
       rules: Check your laws upon being fitted to your chassis. You are a team antagonist, and your goal is to kill everyone you can on the station, bring them back to your ship, gib them, and borg them. Exercise prudence about your targetting as you are made of flesh, and therefore feeble.
+      mindRoles: [MindRoleXenoborg]
       important: true # SL
       raffle:
         settings: default