Merge pull request #1180 from ss14Starlight/starlight-dev

Fix Characters Sizes

Author: Happyrobot33

Content.Client/Humanoid/HumanoidAppearanceSystem.cs

@@ -57,11 +57,11 @@ private void UpdateSprite(Entity<HumanoidAppearanceComponent, SpriteComponent> e
         //starlight start
         if (humanoidAppearance.EyeGlowing)
             sprite.LayerSetShader(HumanoidVisualLayers.Eyes, "unshaded");
-        else 
+        else
             if(_sprite.LayerMapTryGet((entity.Owner, sprite), HumanoidVisualLayers.Eyes, out var layerIndex, true))
                 sprite.LayerSetShader(layerIndex, (ShaderInstance?)null);
 
-        sprite.Scale = new Vector2(humanoidAppearance.Width, humanoidAppearance.Height);
+        sprite.Scale = new Vector2(humanoidAppearance.Width * humanoidAppearance.Height, humanoidAppearance.Height);
         //starlight end
     }
 
@@ -249,7 +249,7 @@ public void AddCustomBaseLayers(EntityUid uid, Dictionary<HumanoidVisualLayers,
         {
             return;
         }
-        
+
         humanoid.CustomBaseLayers = layers;
         UpdateSprite((uid, humanoid, Comp<SpriteComponent>(uid)));
     }

Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs

@@ -484,7 +484,7 @@ public HumanoidProfileEditor(
             Markings.OnMarkingRankChange += OnMarkingChange;
 
             #endregion Markings
-            
+
             // Starlight
             #region Cybernetics
             TabContainer.SetTabTitle(5, Loc.GetString("humanoid-profile-editor-cybernetics-tab"));
@@ -1333,8 +1333,8 @@ private void SetGender(Gender newGender)
         private void UpdateSizeText() {
             if(Profile is null) return;
             if (_prototypeManager.TryIndex<SpeciesPrototype>(Profile.Species, out var speciesPrototype)) {
-                var height = speciesPrototype.StandardSize * Profile.Appearance.Height;
-                var weight = speciesPrototype.StandardWeight + speciesPrototype.StandardDensity * ((Profile.Appearance.Width * Profile.Appearance.Height) - 1);
+                var height = speciesPrototype.StandardSize * (Profile.Appearance.Height - 1f) * 2f + speciesPrototype.StandardSize;
+                var weight = speciesPrototype.StandardWeight + speciesPrototype.StandardDensity * (Profile.Appearance.Width * Profile.Appearance.Height * Profile.Appearance.Height - 1);
                 HeightDescribeLabel.Text = Loc.GetString("humanoid-profile-editor-height-label", ("height", Math.Round(height)));
                 WidthDescribeLabel.Text = Loc.GetString("humanoid-profile-editor-width-label", ("weight", Math.Round(weight, 1)));
             }
@@ -1496,7 +1496,7 @@ private void UpdateSizeControls()
                 HeightSlider.MinValue = speciesPrototype.MinHeight;
                 HeightSlider.MaxValue = speciesPrototype.MaxHeight;
                 HeightSlider.Value = Profile.Appearance.Height;
-                
+
                 UpdateSizeText();
             }
         }

Content.Shared/Humanoid/Prototypes/SpeciesPrototype.cs

@@ -143,13 +143,13 @@ public sealed partial class SpeciesPrototype : IPrototype
     ///     Characters must not crumple under earth-like gravity.
     /// </summary>
     [DataField]
-    public float MinWidth = 0.8f;
+    public float MinWidth = 0.9f;
 
     /// <summary>
     ///     Characters must not exhibit a measurable gravitational pull on nearby objects.
     /// </summary>
     [DataField]
-    public float MaxWidth = 1.2f;
+    public float MaxWidth = 1.1f;
 
     /// <summary>
     ///     The normal width for this species.
@@ -161,13 +161,13 @@ public sealed partial class SpeciesPrototype : IPrototype
     ///     Sentient microbial lifeforms are not currently hireable under contract.
     /// </summary>
     [DataField]
-    public float MinHeight = 0.8f;
+    public float MinHeight = 0.9f;
 
     /// <summary>
     ///     You cannot fit in our cloning pods.
     /// </summary>
     [DataField]
-    public float MaxHeight = 1.2f;
+    public float MaxHeight = 1.15f;
 
     /// <summary>
     ///     The normal height for this species.

Resources/Changelog/ChangelogStarlight.yml

@@ -10021,5 +10021,20 @@ Entries:
   id: 1380
   time: '2025-08-01T04:54:21.000000+00:00'
   url: https://github.com/ss14Starlight/space-station-14/pull/1171
+- author: Arkanic
+  changes:
+  - message: 1984 the character min/max sizes to something more reasonable
+    type: Tweak
+  id: 1381
+  time: '2025-08-01T16:02:15.000000+00:00'
+  url: https://github.com/ss14Starlight/space-station-14/pull/1174
+- author: Arkanic
+  changes:
+  - message: Width slider now acts more like an "aspect ratio" slider to stop goofy
+      min width max height characters
+    type: Tweak
+  id: 1382
+  time: '2025-08-01T16:02:15.000000+00:00'
+  url: https://github.com/ss14Starlight/space-station-14/pull/1174
 Order: -1
 

Resources/Prototypes/Species/dwarf.yml

@@ -7,10 +7,10 @@
   markingLimits: MobHumanMarkingLimits
   dollPrototype: MobDwarfDummy
   skinColoration: HumanToned
-  customName: true # Starlight
-  minWidth: 0.9 # Starlight
-  defaultWidth: 1 # Starlight
-  maxWidth: 1.2 # Starlight
-  minHeight: 0.6 # Starlight
-  defaultHeight: 0.8 # Starlight
-  maxHeight: 0.8 # Starlight
+  customName: true # Starlight start
+  minWidth: 1.25
+  defaultWidth: 1.25
+  maxWidth: 1.5
+  minHeight: 0.8
+  defaultHeight: 0.8
+  maxHeight: 0.85 # Starlight end

Resources/Prototypes/Species/resomi.yml

@@ -17,12 +17,6 @@
   oldAge: 257
   maxAge: 430
   customName: true # Starlight
-  minWidth: 0.9
-  defaultWidth: 1
-  maxWidth: 1.2
-  minHeight: 0.8
-  defaultHeight: 1
-  maxHeight: 1.1
   standardSize: 150
   standardWeight: 40
   standardDensity: 17

Resources/Prototypes/_StarLight/Species/avali.yml

@@ -16,9 +16,6 @@
   youngAge: 103
   oldAge: 257
   maxAge: 430
-  minWidth: 0.8
-  defaultWidth: 0.91
-  maxWidth: 1
   minHeight: 0.8
   defaultHeight: 0.91
   maxHeight: 1

Resources/Prototypes/_StarLight/Species/cyclorite.yml

@@ -12,12 +12,9 @@
   femaleFirstNames: names_cyclorite
   naming: First
   customName: true
-  minWidth: 0.9
-  defaultWidth: 1
-  maxWidth: 1.25
   minHeight: 0.9
   defaultHeight: 1
-  maxHeight: 1.25
+  maxHeight: 1.2
   standardSize: 170
   standardWeight: 100
   standardDensity: 110

Resources/Prototypes/_StarLight/Species/felionoid.yml

@@ -12,10 +12,7 @@
   femaleFirstNames: names_felionoid
   naming: First
   customName: true
-  minWidth: 0.7
-  defaultWidth: 0.8
-  maxWidth: 0.9
-  minHeight: 0.7
+  minHeight: 0.8
   defaultHeight: 0.8
   maxHeight: 0.9
   standardSize: 170

Resources/Prototypes/_StarLight/Species/vulpkanin.yml

@@ -13,7 +13,7 @@
   customName: true
   minHeight: 0.9
   defaultHeight: 1
-  maxHeight: 1.25
+  maxHeight: 1.2
   standardSize: 170
   standardWeight: 75
   standardDensity: 110