Commit 919e001
authored
Dream (Don't) Drop Loadout (#5494)
## Short description
#4958 + Dynamic made it so you can roll antags later into the round, but
this can actually lead to a problem where you end up dropping gear on
the floor. This tries to fix that by dropping things from your equipped
back storage onto the ground if there's not enough room, and, if you're
not weaing back storage, putting it in your hands instead. When both
those cases fail, only then will it drop stuff on the floor.
Pun Pun and others without back storage would actually never get their
gear, so this also allows them to get it via the hand equip.
As I always state when I use AI, I had AI assistance in creating this
PR, mainly with deciphering and rewriting SharedStationSpawningSystem.
## Why we need to add this
Antags dropping their stuff is a pretty bad new player trap.
## Media (Video/Screenshots)
[Content.Client_Kkm9myix1d.webm](https://github.com/user-attachments/assets/3ca35e6a-6b75-4a2b-acfa-7a036d114302)
[Content.Client_6O0N1zPo4J.webm](https://github.com/user-attachments/assets/33e488f3-1a10-45f0-877a-3397f365b4bd)
<img width="363" height="414" alt="image"
src="https://github.com/user-attachments/assets/eeef771c-dea3-41e2-b8a1-0f152ab38845"
/>
## Checks
- [X] I do not require assistance to complete the PR.
- [X] Before posting/requesting review of a PR, I have verified that the
changes work.
- [X] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [X] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.
**Changelog**
:cl: wonderfulnewworld
- fix: When you roll an antag that adds items to your inventory, if your
back storage doesn't have enough room, it'll drop enough items from your
back storage to fit your new gear in. If you're not wearing back
storage, or your back storage is too small, it'll put them in your hands
instead. Failing both of those cases, then it'll drop them on the floor.
- fix: Pun Pun and other non-bag equippers can now actually get their
Thief and SELF gear.1 parent 373ba58 commit 919e001
3 files changed
Lines changed: 263 additions & 48 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1158 | 1158 | | |
1159 | 1159 | | |
1160 | 1160 | | |
1161 | | - | |
| 1161 | + | |
1162 | 1162 | | |
1163 | 1163 | | |
1164 | 1164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
| 157 | + | |
157 | 158 | | |
158 | 159 | | |
| 160 | + | |
| 161 | + | |
159 | 162 | | |
160 | 163 | | |
161 | | - | |
| 164 | + | |
162 | 165 | | |
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
166 | | - | |
| 169 | + | |
167 | 170 | | |
168 | 171 | | |
169 | 172 | | |
| |||
181 | 184 | | |
182 | 185 | | |
183 | 186 | | |
184 | | - | |
| 187 | + | |
185 | 188 | | |
186 | 189 | | |
187 | 190 | | |
| |||
0 commit comments