Skip to content

Commit 9ae6e4a

Browse files
authored
fix the ghost of Dev on remix (#5914)
## Short description <!-- What do you propose to change with your PR? --> ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> ## Media (Video/Screenshots) <img width="1052" height="95" alt="image" src="https://github.com/user-attachments/assets/4a1a81ee-ae2a-463c-ac96-1daabf11e0b6" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: - fix: Remix admeme station no-longer has a ghost of dev station providing unlimited captain slots and a 2nd arrivals shuttle.
1 parent 3637d90 commit 9ae6e4a

2 files changed

Lines changed: 15399 additions & 15464 deletions

File tree

Content.IntegrationTests/Tests/Power/StationPowerTests.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,15 @@ public sealed class StationPowerTests : GameTest
7575
#endregion
7676
];
7777

78+
#region Starlight
79+
/// <summary>
80+
/// Starlight: allows specific maps to skip having a upper bound on power in the case of admeme maps or where it is deemed acceptable by head mapper
81+
/// </summary>
82+
private static readonly HashSet<string> _noUpperBoundedPowerMaps = [
83+
"StarlightRemix"
84+
];
85+
#endregion
86+
7887
public override PoolSettings PoolSettings => new ()
7988
{
8089
Dirty = true,
@@ -257,6 +266,8 @@ await server.WaitAssertion(() =>
257266
Assert.That(totalStartingCharge, Is.GreaterThanOrEqualTo(requiredStoredPower),
258267
$"Needs at least {requiredStoredPower - totalStartingCharge} more stored power!");
259268
// Starlight start
269+
if (_noUpperBoundedPowerMaps.Contains(mapProtoId))
270+
return; //skip the section below if it is a no upper bound map.
260271
Assert.That(estimatedDuration, Is.LessThanOrEqualTo(MaximumPowerDurationSeconds),
261272
$"Initial power for {mapProtoId} lasts too long! Max allowed {MaximumPowerDurationSeconds}s " +
262273
$"but estimated to last {estimatedDuration}s remove some stored power!");

0 commit comments

Comments
 (0)