Commit a05b0b5
authored
Fix K9 identity concealment issue (#5954)
## Short description
<!-- What do you propose to change with your PR? -->
Adds an AlwaysIdentifiableComponent to the IdentitySystem to ignore the
IdentitySystem's concealment code.
## Why we need to add this
<!-- What is the reason for adding these changes? Please post links to
Discussions as well as Bug Reports here. Please describe how this will
change the game balance. -->
I added #5816 to allow smart corgis and animals to begin to leverage the
identity system.
K9s do NOT have an ID slot and as such immediately fail to identify with
their sec mask on.
With this change, K9s will be always identifiable.
This isn't a permanent solution to the matter; there is an in-flight bit
of dev work going on in the 'Security K9' channel in #pr-workshop that
is working to add collars in lieu of the existing system for K9s
(tracking implanter and bespoke job identification code). Collars will
act as PDAs with suit coordinates.
Until that's done, this will help maintain gameplay-as-intended. The
component is also decent for other situations that might spring up where
something may need to be always identifiable.
## Media (Video/Screenshots)
<!--
If your PR contains in-game changes you must provide screenshots/videos
of the changes.
-->
Fixes this:
<img width="388" height="205" alt="image"
src="https://github.com/user-attachments/assets/cd8f4b35-9dd3-4a06-95a7-69a2b84aed37"
/>
## Checks
<!-- check boxes for faster reviewing of your PR -->
- [X] I do not require assistance to complete the PR.
- [X] Before posting/requesting review of a PR, I have verified that the
changes work.
- [X] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [X] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.
**Changelog**
:cl: Sparlight
- fix: K9s will no longer suffer abject identity concealment issues.
<!--
If you want the players to know about changes made in this PR, specify
them using the template outside the comment. Short and informative.
:cl: STARLIGHT TEAM
- add: Added Starlight.
- remove: Removed SS13.
- tweak: Changed SS14.
- fix: Fixed Rinary.
-->1 parent d78a1de commit a05b0b5
4 files changed
Lines changed: 35 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
198 | 197 | | |
199 | 198 | | |
200 | 199 | | |
201 | | - | |
202 | | - | |
| 200 | + | |
203 | 201 | | |
204 | | - | |
205 | 202 | | |
206 | 203 | | |
207 | 204 | | |
| |||
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| |||
0 commit comments