diff --git a/.github/labeler.yml b/.github/labeler.yml index ca5aeed1f3ca..08c61e61d404 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -24,3 +24,7 @@ - changed-files: # Equiv to any-glob-to-all as long as this has one matcher. If ALL changed files are not C# files, then apply label. - all-globs-to-all-files: "!**/*.cs" + +"Changes: C#": +- changed-files: + - any-glob-to-any-file: '**/*.cs' \ No newline at end of file diff --git a/.github/workflows/auto-assign.yml b/.github/workflows/auto-assign.yml index b784d027bd7d..aa8e01a72df4 100644 --- a/.github/workflows/auto-assign.yml +++ b/.github/workflows/auto-assign.yml @@ -19,9 +19,10 @@ jobs: "Changes: Sprites": ["BORTBORTBORTBORTBORT"], "Changes: Map": ["PubliclyExecutedPig"], "Changes: UI": ["ss14-Starlight"], - "Changes: Shaders": ["ss14-Starlight"], - "Changes: Audio": ["ss14-Starlight"], - "Changes: No C#": ["ss14-Starlight"], + "Changes: Shaders": ["ss14-Starlight, Happyrobot33, FoxxoTrystan"], + "Changes: Audio": ["ss14-Starlight, Happyrobot33, FoxxoTrystan"], + "Changes: No C#": ["ss14-Starlight, Happyrobot33, FoxxoTrystan"], + "Changes: C#": ["ss14-Starlight, Happyrobot33, FoxxoTrystan"], }; const labels = context.payload.pull_request.labels.map(label => label.name); diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 0c6e10a2be34..ffee660a589b 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -51,7 +51,7 @@ jobs: update-changelog: name: Publish Changelogs - needs: build +# needs: build runs-on: ubuntu-latest environment: prod steps: diff --git a/.github/workflows/target-branch-validation.yml b/.github/workflows/target-branch-validation.yml new file mode 100644 index 000000000000..e022c2a82993 --- /dev/null +++ b/.github/workflows/target-branch-validation.yml @@ -0,0 +1,32 @@ +name: Check PR Target Branch + +on: + pull_request: + types: [opened, synchronize, reopened, edited] + +jobs: + check-target-branch: + runs-on: ubuntu-latest + + steps: + - name: Check if PR targets starlight-dev + run: | + SOURCE_BRANCH="${{ github.event.pull_request.head.ref }}" + TARGET_BRANCH="${{ github.event.pull_request.base.ref }}" + echo "PR from: $SOURCE_BRANCH -> $TARGET_BRANCH" + + # Allow starlight-dev to starlight PRs in both directions + if [[ ("$SOURCE_BRANCH" == "starlight-dev" && "$TARGET_BRANCH" == "starlight") || + ("$SOURCE_BRANCH" == "starlight" && "$TARGET_BRANCH" == "starlight-dev") ]]; then + echo "Allowed: PR between starlight-dev and starlight branches" + exit 0 + fi + + # For all other PRs, require starlight-dev as target + if [ "$TARGET_BRANCH" != "starlight-dev" ]; then + echo "Error: PR must target 'starlight-dev' branch, but targets '$TARGET_BRANCH'" + echo "Please change the target branch to 'starlight-dev'" + exit 1 + else + echo "Success: PR correctly targets 'starlight-dev' branch" + fi diff --git a/Content.Client/Actions/ActionsSystem.cs b/Content.Client/Actions/ActionsSystem.cs index 3bfacb5bc6e8..8efe0b2367f8 100644 --- a/Content.Client/Actions/ActionsSystem.cs +++ b/Content.Client/Actions/ActionsSystem.cs @@ -334,7 +334,12 @@ private void OnWorldTargetAttempt(Entity ent, ref Ac private void OnEntityTargetAttempt(Entity ent, ref ActionTargetAttemptEvent args) { - if (args.Handled || args.Input.EntityUid is not { Valid: true } entity) + if (args.Handled) + return; + + args.Handled = true; + + if (args.Input.EntityUid is not { Valid: true } entity) return; // let world target component handle it @@ -345,8 +350,6 @@ private void OnEntityTargetAttempt(Entity ent, ref return; } - args.Handled = true; - var action = args.Action; var user = args.User; diff --git a/Content.Client/Administration/UI/AdminCamera/AdminCameraControl.xaml b/Content.Client/Administration/UI/AdminCamera/AdminCameraControl.xaml new file mode 100644 index 000000000000..1413eff00c57 --- /dev/null +++ b/Content.Client/Administration/UI/AdminCamera/AdminCameraControl.xaml @@ -0,0 +1,20 @@ + + + + + + + + + +