test(service): <- update tokens

Author: riccardo-ssvlabs

src/BasedAppManager.sol

@@ -257,6 +257,11 @@ contract BasedAppManager is Initializable, OwnableUpgradeable, UUPSUpgradeable {
     function addTokensToService(address serviceAddress, address[] calldata tokens) external {
         ICore.Service storage service = services[serviceAddress];
         for (uint256 i = 0; i < tokens.length; i++) {
+            for (uint256 j = 0; j < service.tokens.length; j++) {
+                if (service.tokens[j] == tokens[i]) {
+                    revert("Token already added");
+                }
+            }
             service.tokens.push(tokens[i]);
         }
         emit ServiceTokensUpdated(serviceAddress, tokens);

test/BasedAppManager.t.sol

@@ -711,5 +711,24 @@ contract BasedAppManagerTest is Test, OwnableUpgradeable {
         vm.stopPrank();
     }
 
-    function testUpdateService() public {}
+    function testUpdateServiceWithNewTokens() public {
+        testRegisterService();
+        vm.startPrank(USER1);
+        address[] memory tokensInput = new address[](2);
+        tokensInput[0] = address(erc20mock2);
+        tokensInput[1] = address(ETH_ADDRESS);
+        proxiedManager.addTokensToService(SERVICE1, tokensInput);
+        vm.stopPrank();
+    }
+
+    function testUpdateServiceWithAlreadyPresentTokensRevert() public {
+        testRegisterService();
+        vm.startPrank(USER1);
+        address[] memory tokensInput = new address[](2);
+        tokensInput[0] = address(erc20mock);
+        tokensInput[1] = address(ETH_ADDRESS);
+        vm.expectRevert("Token already added");
+        proxiedManager.addTokensToService(SERVICE1, tokensInput);
+        vm.stopPrank();
+    }
 }