Skip to content

TestingBeaconNode funcs should return data matching spec-tests expectations #587

@iurii-ssv

Description

@iurii-ssv

While implementing this adjustment - ssvlabs/ssv#2562 - we've discovered that in spec-tests BeaconNodeWrapped that relies on TestingBeaconNode (from ssv-spec repo) hardcodes the data it returns,

specifically for GetBeaconBlock endpoint:

This worked so far due to some "correct hardcoding" in place, but with ssvlabs/ssv#2562 the behavior in ssv repo changes - now, when we get a full block from the Beacon node (TestingBeaconNode), we are "creating" a blinded block ourselves (and SZZ-encode the result to use in QBFT consensus)

and so the spec-test mentioned above fails now,

Solution(s):

  • perhaps we can do some more of elaborate hardcoding, but
  • the correct general-purpose solution would require updating spec-tests such that the results TestingBeaconNode funcs/endpoints returns be parametrizable by every individual spec-test as needed (if spec-tests works with blinded block(s) - BeaconNodeWrapped would return blinded blocks, etc.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions