not able to find v4.5

[JinoArch]

I am facing the following issue while running GitHub Actions.

Prepare all required actions
Getting action download info
Error: Unable to resolve action `stCarolas/setup-maven@v4.5`, unable to find version `v4.5`

Looks like release name/code needs update ? https://github.com/stCarolas/setup-maven/releases ?

updated snippet as

- name: Set up Maven
      uses: stCarolas/setup-maven@v4.5
      with:
        maven-version: 3.8.2

as per https://github.com/marketplace/actions/setup-maven?version=v.4.5
May be I have to try 4.4!

[slawekjaranowski]

The tag name is v.4.5 - dot after v - probably misspell in tag name

[JinoArch]

The tag name is v.4.5 - dot after v - probably misspell in tag name

Then I think we need update in here too? https://github.com/marketplace/actions/setup-maven?version=v.4.5

 uses: stCarolas/setup-maven@v4.5

[joakime]

Those of us using codeql are getting warnings with v4.4 (or older) versions of setup-maven (as codeql based builds are now enforcing node-16)
And this new not-quite-a-version was a bit of a surprise.

[JinoArch]

Thanks. no more warnings in GHA. Please close this one. :)

[evie-lau]

I still think this is a valid issue to fix in this repo, as the tag should have been v4.5 and not v.4.5

[kherock]

Yes this was really hard to discover especially since the release isn't titled with the version number either - can an extra tag v4.5 be pushed onto the latest release please?

[stCarolas]

v4.5 pushed
https://github.com/stCarolas/setup-maven/releases/tag/v4.5
Should be fine now

[aabeling]

How about moving the tag v4 to point to v4.5? I thought this would be the best practice: https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

[famod]

How about moving the tag v4 to point to v4.5? I thought this would be the best practice: https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

Definitely surprising that this actions doesn't follow this pattern (yet). So +1 from me!

[famod]

Btw, I think dependabot also considers v4 to be a floating tag because I haven't received any update PRs for this action in https://github.com/gitflow-incremental-builder/gitflow-incremental-builder and I have enabled action updates via dependabot for quite some time now.