Fix curl-share handling on PHP < 8.5

Author: staabm

src/utils/HttpClient.php

@@ -8,6 +8,11 @@
 
 final class HttpClient
 {
+    /**
+     * @var \CurlShareHandle|resource|null
+     */
+    private $shareHandle = null;
+
     /**
      * @param non-empty-array<non-empty-string> $urls
      * @param list<string> $headers
@@ -16,15 +21,19 @@ final class HttpClient
      */
     public function getMulti(array $urls, array $headers): array
     {
-        if (function_exists('curl_share_init_persistent')) {
-            $share = curl_share_init_persistent([
-                CURL_LOCK_DATA_DNS,
-                CURL_LOCK_DATA_CONNECT,
-            ]);
-        } else {
-            $share = curl_share_init();
-            curl_share_setopt($share, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS);
-            curl_share_setopt($share, CURLSHOPT_SHARE, CURL_LOCK_DATA_CONNECT);
+        if ($this->shareHandle === null) {
+            if (function_exists('curl_share_init_persistent')) {
+                $this->shareHandle = curl_share_init_persistent([
+                    CURL_LOCK_DATA_DNS,
+                    CURL_LOCK_DATA_CONNECT,
+                    CURL_LOCK_DATA_SSL_SESSION
+                ]);
+            } else {
+                $this->shareHandle = curl_share_init();
+                curl_share_setopt($this->shareHandle, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS);
+                curl_share_setopt($this->shareHandle, CURLSHOPT_SHARE, CURL_LOCK_DATA_CONNECT);
+                curl_share_setopt($this->shareHandle, CURLSHOPT_SHARE, CURL_LOCK_DATA_SSL_SESSION);
+            }
         }
 
         $mh = curl_multi_init();
@@ -37,7 +46,7 @@ public function getMulti(array $urls, array $headers): array
                 throw new RuntimeException('Could not initialize cURL connection');
             }
 
-            curl_setopt($curl, CURLOPT_SHARE, $share);
+            curl_setopt($curl, CURLOPT_SHARE, $this->shareHandle);
 
             // see https://stackoverflow.com/a/27776164/1597388
             curl_setopt($curl, CURLOPT_CONNECTTIMEOUT, 3);