TodoByPackageVersionRule uses PHPStan's InstalledVersions class

[ruudk]

Thanks for this amazing extension.

I just noticed that the TodoByPackageVersionRule is not working properly.

It's reading the installed versions from phar:///Volumes/CS/www/cosmos/vendor/phpstan/phpstan/phpstan.phar/vendor/composer/InstalledVersions.php

See

This makes checks like this:

// TODO symfony/console:v7.3.0 test this should trigger

Worthless, because they are always compared to PHPStan's version of Console, which is:
https://github.com/phpstan/phpstan-src/blob/c0f2e9e9235db973784d88b107bc8c14ecb647d0/composer.json#L42

[ruudk]

There is some logic in

phpstan-todo-by/src/TodoByPackageVersionRule.php

Lines 76 to 80 in faf9020

	// require the top level installed versions, so we don't mix it up with the one in phpstan.phar
	$installedVersions = $this->workingDirectory . '/vendor/composer/InstalledVersions.php';
	if (!class_exists(InstalledVersions::class, false) && is_readable($installedVersions)) {
	require_once $installedVersions;
	}

but it doesn't seem to work as expected.

I was wondering, why not read vendor/composer/installed.json or vendor/composer/installed.php instead? This might solve the problem with the InstalledVersions class already being loaded.

[ruudk]

This solves the problem:

• Use vendor/composer/installed.php in TodoByPackageVersionRule.php #147

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.