Skip to content

Should exit non-zero following an exception #466

@captaincoordinates

Description

@captaincoordinates

Currently validation exits with a zero exit code if an exception occurs (e.g. connection reset by peer), potentially giving the false impression of a successful validation result.

__main__.py returns here. The returned int is ignored and the script completes normally.

I suggest __main__.py should instead call sys.exit(1) as it does in the case of validation errors.

I'm happy to submit a PR if you agree that this issue is worth addressing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions