Skip to content

Commit 03f0873

Browse files
committed
Make function name explicit
1 parent b7f22c3 commit 03f0873

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Diff for: stac_pydantic/extensions.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212

1313
@lru_cache(maxsize=128)
14-
def _fetch_schema(url: str) -> dict:
14+
def _fetch_and_cache_schema(url: str) -> dict:
1515
"""Fetch the remote JSON schema, if not already cached."""
1616
req = requests.get(url)
1717
return req.json()
@@ -35,7 +35,7 @@ def validate_extensions(
3535
try:
3636
if stac_dict["stac_extensions"]:
3737
for ext in stac_dict["stac_extensions"]:
38-
schema = _fetch_schema(ext)
38+
schema = _fetch_and_cache_schema(ext)
3939
jsonschema.validate(instance=stac_dict, schema=schema)
4040
except Exception:
4141
if reraise_exception:

Diff for: tests/test_models.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from shapely.geometry import shape
77

88
from stac_pydantic import Collection, Item, ItemProperties
9-
from stac_pydantic.extensions import _fetch_schema, validate_extensions
9+
from stac_pydantic.extensions import _fetch_and_cache_schema, validate_extensions
1010
from stac_pydantic.links import Link, Links
1111
from stac_pydantic.shared import MimeTypes, StacCommonMetadata
1212

@@ -120,16 +120,16 @@ def test_extension_validation_schema_cache() -> None:
120120
# Defines 3 extensions, but one is a non-existing URL
121121
test_item = request(EO_EXTENSION)
122122

123-
_fetch_schema.cache_clear()
123+
_fetch_and_cache_schema.cache_clear()
124124

125125
assert not validate_extensions(test_item)
126-
assert _fetch_schema.cache_info().hits == 0
127-
assert _fetch_schema.cache_info().misses == 3
126+
assert _fetch_and_cache_schema.cache_info().hits == 0
127+
assert _fetch_and_cache_schema.cache_info().misses == 3
128128

129129
assert not validate_extensions(test_item)
130-
assert _fetch_schema.cache_info().hits == 2
130+
assert _fetch_and_cache_schema.cache_info().hits == 2
131131
# The non-existing URL will have failed, hence retried
132-
assert _fetch_schema.cache_info().misses == 4
132+
assert _fetch_and_cache_schema.cache_info().misses == 4
133133

134134

135135
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)