fix(vue): suppress callback error

stackblitz · Oct 5, 2024 · 678da8b · 678da8b
1 parent 2a6ff9f
commit 678da8b
Showing 1 changed file with 1 addition and 12 deletions.
diff --git a/unstable/vue.ts b/unstable/vue.ts
@@ -21,9 +21,7 @@ class VueEffectScope extends EffectScope {
 
 	stop() {
 		super.stop();
-		for (const cb of this.onDispose) {
-			cb();
-		}
+		this.onDispose.forEach(cb => cb());
 	}
 }
 
@@ -78,12 +76,6 @@ class VueComputed<T = any> extends Computed<T> {
 }
 
 export class ReactiveEffect extends Effect {
-	onDispose: (() => void)[] = [];
-
-	constructor(fn: () => void) {
-		super(fn);
-	}
-
 	get dirty() {
 		if (this.versionOrDirtyLevel === DirtyLevels.MaybeDirty) {
 			Subscriber.resolveMaybeDirty(this);
@@ -97,9 +89,6 @@ export class ReactiveEffect extends Effect {
 
 	stop() {
 		Subscriber.clearTrack(this);
-		for (const cb of this.onDispose) {
-			cb();
-		}
 	}
 }