Merge pull request #30 from illambo/master

marickvantuil · web-flow · commit c12ca2b6b0ce · 2021-08-21T22:12:53.000+02:00
Fix cache expiration condition
diff --git a/src/OpenIdVerificator.php b/src/OpenIdVerificator.php
@@ -50,9 +50,9 @@ public function decodeOpenIdToken($openIdToken, $kid, $cache = true)
 
     public function getPublicKey($kid = null)
     {
-        if (Cache::has(self::V3_CERTS)) {
-            $v3Certs = Cache::get(self::V3_CERTS);
-        } else {
+        $v3Certs = Cache::get(self::V3_CERTS);
+        
+        if (is_null($v3Certs)) {
             $v3Certs = $this->getFreshCertificates();
             Cache::put(self::V3_CERTS, $v3Certs, Carbon::now()->addSeconds($this->maxAge[self::URL_OPENID_CONFIG]));
         }

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,9 @@ public function decodeOpenIdToken($openIdToken, $kid, $cache = true)`
`50`	`50`
`51`	`51`	`public function getPublicKey($kid = null)`
`52`	`52`	`{`
`53`		`- if (Cache::has(self::V3_CERTS)) {`
`54`		`- $v3Certs = Cache::get(self::V3_CERTS);`
`55`		`- } else {`
	`53`	`+ $v3Certs = Cache::get(self::V3_CERTS);`
	`54`	`+`
	`55`	`+ if (is_null($v3Certs)) {`
`56`	`56`	`$v3Certs = $this->getFreshCertificates();`
`57`	`57`	`Cache::put(self::V3_CERTS, $v3Certs, Carbon::now()->addSeconds($this->maxAge[self::URL_OPENID_CONFIG]));`
`58`	`58`	`}`