-
Notifications
You must be signed in to change notification settings - Fork 234
Expand file tree
/
Copy pathmiddleware.go
More file actions
496 lines (443 loc) · 20.1 KB
/
Copy pathmiddleware.go
File metadata and controls
496 lines (443 loc) · 20.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
// SPDX-FileCopyrightText: Copyright 2025 Stacklok, Inc.
// SPDX-License-Identifier: Apache-2.0
package runner
import (
"fmt"
"log/slog"
"github.com/stacklok/toolhive/pkg/audit"
"github.com/stacklok/toolhive/pkg/auth"
"github.com/stacklok/toolhive/pkg/auth/awssts"
"github.com/stacklok/toolhive/pkg/auth/obo"
"github.com/stacklok/toolhive/pkg/auth/upstreamswap"
"github.com/stacklok/toolhive/pkg/authserver"
"github.com/stacklok/toolhive/pkg/authz"
"github.com/stacklok/toolhive/pkg/authz/authorizers/cedar"
cfg "github.com/stacklok/toolhive/pkg/config"
"github.com/stacklok/toolhive/pkg/mcp"
"github.com/stacklok/toolhive/pkg/oauthproto/tokenexchange"
"github.com/stacklok/toolhive/pkg/ratelimit"
"github.com/stacklok/toolhive/pkg/recovery"
"github.com/stacklok/toolhive/pkg/telemetry"
headerfwd "github.com/stacklok/toolhive/pkg/transport/middleware"
"github.com/stacklok/toolhive/pkg/transport/middleware/origin"
"github.com/stacklok/toolhive/pkg/transport/types"
"github.com/stacklok/toolhive/pkg/usagemetrics"
"github.com/stacklok/toolhive/pkg/webhook/mutating"
"github.com/stacklok/toolhive/pkg/webhook/validating"
)
// GetSupportedMiddlewareFactories returns a map of supported middleware types to their factory functions
func GetSupportedMiddlewareFactories() map[string]types.MiddlewareFactory {
return map[string]types.MiddlewareFactory{
auth.MiddlewareType: auth.CreateMiddleware,
tokenexchange.MiddlewareType: tokenexchange.CreateMiddleware,
upstreamswap.MiddlewareType: upstreamswap.CreateMiddleware,
awssts.MiddlewareType: awssts.CreateMiddleware,
obo.MiddlewareType: obo.CreateMiddleware,
mcp.ParserMiddlewareType: mcp.CreateParserMiddleware,
mcp.ToolFilterMiddlewareType: mcp.CreateToolFilterMiddleware,
mcp.ToolCallFilterMiddlewareType: mcp.CreateToolCallFilterMiddleware,
ratelimit.MiddlewareType: ratelimit.CreateMiddleware,
usagemetrics.MiddlewareType: usagemetrics.CreateMiddleware,
telemetry.MiddlewareType: telemetry.CreateMiddleware,
authz.MiddlewareType: authz.CreateMiddleware,
audit.MiddlewareType: audit.CreateMiddleware,
recovery.MiddlewareType: recovery.CreateMiddleware,
headerfwd.HeaderForwardMiddlewareName: headerfwd.CreateMiddleware,
origin.MiddlewareType: origin.CreateMiddleware,
validating.MiddlewareType: validating.CreateMiddleware,
mutating.MiddlewareType: mutating.CreateMiddleware,
}
}
// PopulateMiddlewareConfigs populates the MiddlewareConfigs slice based on the RunConfig settings
// This function serves as a bridge between the old configuration style and the new generic middleware system
//
//nolint:gocyclo // Function complexity is acceptable for middleware configuration
func PopulateMiddlewareConfigs(config *RunConfig) error {
var middlewareConfigs []types.MiddlewareConfig
// TODO: Consider extracting other middleware setup into helper functions like addUsageMetricsMiddleware
//
// NOTE: Origin-validation middleware is intentionally NOT added here. It is
// wired centrally in runner.Run (via prependOriginMiddleware) for both the
// operator/proxyrunner path (this function) and the CLI path
// (WithMiddlewareFromFlags), because that is the only place where the
// effective Host/Port/AllowedOrigins are fully resolved.
// Authentication middleware (always present)
authParams := auth.MiddlewareParams{
OIDCConfig: config.OIDCConfig,
}
authConfig, authErr := types.NewMiddlewareConfig(auth.MiddlewareType, authParams)
if authErr != nil {
return fmt.Errorf("failed to create auth middleware config: %w", authErr)
}
middlewareConfigs = append(middlewareConfigs, *authConfig)
// Upstream swap middleware (if embedded auth server is configured)
// This exchanges ToolHive JWTs for upstream IdP tokens when embedded auth server is used.
// IMPORTANT: Must run BEFORE token exchange middleware so it can read the `tsid` claim
// from the original ToolHive JWT before any token modification occurs.
middlewareConfigs, err := addUpstreamSwapMiddleware(middlewareConfigs, config)
if err != nil {
return err
}
// Token exchange middleware (if configured)
// Runs after upstream swap so that if both are configured, upstream swap can first
// inject the upstream IdP token, then token exchange can further transform it if needed.
middlewareConfigs, err = addTokenExchangeMiddleware(middlewareConfigs, config.TokenExchangeConfig)
if err != nil {
return err
}
// Tools filter and override middleware (if enabled)
if len(config.ToolsFilter) > 0 || len(config.ToolsOverride) > 0 {
// Prepare overrides map (convert runner.ToolOverride -> mcp.ToolOverride)
overrides := make(map[string]mcp.ToolOverride)
for actualName, tool := range config.ToolsOverride {
overrides[actualName] = mcp.ToolOverride{
Name: tool.Name,
Description: tool.Description,
}
}
// Add tool filter middleware with both filter and overrides
toolFilterParams := mcp.ToolFilterMiddlewareParams{
FilterTools: config.ToolsFilter,
ToolsOverride: overrides,
}
toolFilterConfig, err := types.NewMiddlewareConfig(mcp.ToolFilterMiddlewareType, toolFilterParams)
if err != nil {
return fmt.Errorf("failed to create tool filter middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *toolFilterConfig)
// Add tool call filter middleware with same params
toolCallFilterConfig, err := types.NewMiddlewareConfig(mcp.ToolCallFilterMiddlewareType, toolFilterParams)
if err != nil {
return fmt.Errorf("failed to create tool call filter middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *toolCallFilterConfig)
}
// MCP Parser middleware (always present)
mcpParserParams := mcp.ParserMiddlewareParams{}
mcpParserConfig, err := types.NewMiddlewareConfig(mcp.ParserMiddlewareType, mcpParserParams)
if err != nil {
return fmt.Errorf("failed to create MCP parser middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *mcpParserConfig)
// Rate limit middleware (if configured)
// Positioned after MCP parser (needs tool name from context).
// Will also need user identity from auth when per-user limits are added (#4550).
middlewareConfigs, err = addRateLimitMiddleware(middlewareConfigs, config)
if err != nil {
return err
}
// Mutating Webhooks middleware (if configured).
// Must run BEFORE validating webhooks:
// MCP Parser -> [Mutating Webhooks] -> [Validating Webhooks] -> Authz -> Audit
middlewareConfigs, err = addMutatingWebhookMiddleware(middlewareConfigs, config)
if err != nil {
return err
}
// Validating Webhooks middleware (if configured)
middlewareConfigs, err = addValidatingWebhookMiddleware(middlewareConfigs, config)
if err != nil {
return err
}
// Load application config for global settings
configProvider := cfg.NewDefaultProvider()
appConfig := configProvider.GetConfig()
// Usage metrics middleware (if enabled)
middlewareConfigs, err = addUsageMetricsMiddleware(middlewareConfigs, appConfig.DisableUsageMetrics)
if err != nil {
return err
}
// Telemetry middleware (if enabled)
if config.TelemetryConfig != nil {
telemetryParams := telemetry.FactoryMiddlewareParams{
Config: config.TelemetryConfig,
ServerName: config.Name,
Transport: config.Transport.String(),
}
telemetryConfig, err := types.NewMiddlewareConfig(telemetry.MiddlewareType, telemetryParams)
if err != nil {
return fmt.Errorf("failed to create telemetry middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *telemetryConfig)
}
// Authorization middleware (if enabled)
if config.AuthzConfig != nil {
authzCfgData, err := injectUpstreamProviderIfNeeded(config.AuthzConfig, config.EmbeddedAuthServerConfig)
if err != nil {
return fmt.Errorf("failed to inject upstream provider into authorization config: %w", err)
}
authzParams := authz.FactoryMiddlewareParams{
ConfigPath: config.AuthzConfigPath, // Keep for backwards compatibility
ConfigData: authzCfgData, // Use the (possibly-enriched) config data
}
authzConfig, err := types.NewMiddlewareConfig(authz.MiddlewareType, authzParams)
if err != nil {
return fmt.Errorf("failed to create authorization middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *authzConfig)
}
// Audit middleware (if enabled)
if config.AuditConfig != nil {
auditParams := audit.MiddlewareParams{
ConfigPath: config.AuditConfigPath, // Keep for backwards compatibility
ConfigData: config.AuditConfig, // Use the loaded config data
Component: config.AuditConfig.Component,
TransportType: config.Transport.String(), // Pass the actual transport type
}
auditConfig, err := types.NewMiddlewareConfig(audit.MiddlewareType, auditParams)
if err != nil {
return fmt.Errorf("failed to create audit middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *auditConfig)
}
// AWS STS middleware (if configured)
// Placed after audit/authz so that authorization is checked before exchanging
// credentials, and close to the backend so SigV4 signing happens as late as
// possible — minimizing the chance of subsequent middleware invalidating the signature.
middlewareConfigs, err = addAWSStsMiddleware(middlewareConfigs, config)
if err != nil {
return err
}
// Header forward middleware (if configured for remote servers).
// Added near the end so it executes closest to the backend handler (innermost).
// By this point, WithSecrets() has resolved any secret-backed headers
// into resolvedHeaders, so we pass the merged map to the factory.
middlewareConfigs, err = addHeaderForwardMiddleware(middlewareConfigs, config)
if err != nil {
return err
}
// Recovery middleware (always present, added last to be outermost wrapper)
// Middleware is applied in reverse order, so adding last means it executes first
// and catches panics from all other middleware and handlers.
recoveryConfig, err := types.NewMiddlewareConfig(recovery.MiddlewareType, nil)
if err != nil {
return fmt.Errorf("failed to create recovery middleware config: %w", err)
}
middlewareConfigs = append(middlewareConfigs, *recoveryConfig)
// Set the populated middleware configs
config.MiddlewareConfigs = middlewareConfigs
return nil
}
// addMutatingWebhookMiddleware configures the mutating webhook middleware if any webhooks are defined.
// It must be called before addValidatingWebhookMiddleware to preserve the RFC-specified ordering.
func addMutatingWebhookMiddleware(configs []types.MiddlewareConfig, runConfig *RunConfig) ([]types.MiddlewareConfig, error) {
if len(runConfig.MutatingWebhooks) == 0 {
return configs, nil
}
params := mutating.FactoryMiddlewareParams{
MiddlewareParams: mutating.MiddlewareParams{
Webhooks: runConfig.MutatingWebhooks,
},
ServerName: runConfig.Name,
Transport: runConfig.Transport.String(),
}
config, err := types.NewMiddlewareConfig(mutating.MiddlewareType, params)
if err != nil {
return nil, fmt.Errorf("failed to create mutating webhook middleware config: %w", err)
}
return append(configs, *config), nil
}
// addValidatingWebhookMiddleware configures the validating webhook middleware if any webhooks are defined
func addValidatingWebhookMiddleware(configs []types.MiddlewareConfig, runConfig *RunConfig) ([]types.MiddlewareConfig, error) {
if len(runConfig.ValidatingWebhooks) == 0 {
return configs, nil
}
params := validating.FactoryMiddlewareParams{
MiddlewareParams: validating.MiddlewareParams{
Webhooks: runConfig.ValidatingWebhooks,
},
ServerName: runConfig.Name,
Transport: runConfig.Transport.String(),
}
config, err := types.NewMiddlewareConfig(validating.MiddlewareType, params)
if err != nil {
return nil, fmt.Errorf("failed to create validating webhook middleware config: %w", err)
}
return append(configs, *config), nil
}
// addTokenExchangeMiddleware adds token exchange middleware if configured
func addTokenExchangeMiddleware(
middlewares []types.MiddlewareConfig,
tokenExchangeConfig *tokenexchange.Config,
) ([]types.MiddlewareConfig, error) {
if tokenExchangeConfig == nil {
return middlewares, nil
}
tokenExchangeParams := tokenexchange.MiddlewareParams{
TokenExchangeConfig: tokenExchangeConfig,
}
tokenExchangeMwConfig, err := types.NewMiddlewareConfig(
tokenexchange.MiddlewareType,
tokenExchangeParams,
)
if err != nil {
return nil, fmt.Errorf("failed to create token exchange middleware config: %w", err)
}
return append(middlewares, *tokenExchangeMwConfig), nil
}
// addHeaderForwardMiddleware adds header forward middleware if configured for remote servers
func addHeaderForwardMiddleware(middlewares []types.MiddlewareConfig, config *RunConfig) ([]types.MiddlewareConfig, error) {
if config.RemoteURL == "" || !config.HeaderForward.HasHeaders() {
return middlewares, nil
}
headerForwardParams := headerfwd.HeaderForwardMiddlewareParams{
AddHeaders: config.HeaderForward.ResolvedHeaders(),
}
headerForwardConfig, err := types.NewMiddlewareConfig(headerfwd.HeaderForwardMiddlewareName, headerForwardParams)
if err != nil {
return nil, fmt.Errorf("failed to create header forward middleware config: %w", err)
}
return append(middlewares, *headerForwardConfig), nil
}
// addUsageMetricsMiddleware adds usage metrics middleware if enabled
func addUsageMetricsMiddleware(middlewares []types.MiddlewareConfig, configDisabled bool) ([]types.MiddlewareConfig, error) {
if !usagemetrics.ShouldEnableMetrics(configDisabled) {
return middlewares, nil
}
usageMetricsParams := usagemetrics.MiddlewareParams{}
usageMetricsConfig, err := types.NewMiddlewareConfig(usagemetrics.MiddlewareType, usageMetricsParams)
if err != nil {
return nil, fmt.Errorf("failed to create usage metrics middleware config: %w", err)
}
return append(middlewares, *usageMetricsConfig), nil
}
// addUpstreamSwapMiddleware adds upstream swap middleware if the embedded auth server is configured.
// This middleware exchanges ToolHive JWTs for upstream IdP tokens.
// The middleware is only added when EmbeddedAuthServerConfig is set; if UpstreamSwapConfig
// is nil, default configuration values are used.
func addUpstreamSwapMiddleware(
middlewares []types.MiddlewareConfig,
config *RunConfig,
) ([]types.MiddlewareConfig, error) {
// Only add middleware if embedded auth server is configured
if config.EmbeddedAuthServerConfig == nil {
return middlewares, nil
}
// Use provided config or defaults
upstreamSwapConfig := config.UpstreamSwapConfig
if upstreamSwapConfig == nil {
upstreamSwapConfig = &upstreamswap.Config{}
}
// Derive ProviderName from the upstream config if not explicitly set
if upstreamSwapConfig.ProviderName == "" {
upstreamSwapConfig.ProviderName = func() string {
if cfg := config.EmbeddedAuthServerConfig; cfg != nil &&
len(cfg.Upstreams) > 0 {
return authserver.ResolveUpstreamName(cfg.Upstreams[0].Name)
}
return authserver.DefaultUpstreamName
}()
}
upstreamSwapParams := upstreamswap.MiddlewareParams{
Config: upstreamSwapConfig,
}
upstreamSwapMwConfig, err := types.NewMiddlewareConfig(
upstreamswap.MiddlewareType,
upstreamSwapParams,
)
if err != nil {
return nil, fmt.Errorf("failed to create upstream swap middleware config: %w", err)
}
return append(middlewares, *upstreamSwapMwConfig), nil
}
// injectUpstreamProviderIfNeeded enriches an authz.Config with the
// PrimaryUpstreamProvider derived from the embedded auth server config.
// When the embedded auth server is active, Cedar policies should evaluate
// claims from the upstream IDP token rather than the ToolHive-issued JWT.
// If embeddedCfg is nil the original authzCfg is returned unchanged.
func injectUpstreamProviderIfNeeded(
authzCfg *authz.Config,
embeddedCfg *authserver.RunConfig,
) (*authz.Config, error) {
if embeddedCfg == nil {
return authzCfg, nil
}
// Derive the provider name the same way addUpstreamSwapMiddleware does,
// delegating normalisation (empty-string → "default") to ResolveUpstreamName.
providerName := func() string {
if len(embeddedCfg.Upstreams) > 0 {
return authserver.ResolveUpstreamName(embeddedCfg.Upstreams[0].Name)
}
return authserver.DefaultUpstreamName
}()
return cedar.InjectUpstreamProvider(authzCfg, providerName)
}
// addAWSStsMiddleware adds AWS STS middleware if configured.
// Returns an error if AWSStsConfig is set but RemoteURL is empty, because
// SigV4 signing is only meaningful for remote MCP servers.
func addAWSStsMiddleware(middlewares []types.MiddlewareConfig, config *RunConfig) ([]types.MiddlewareConfig, error) {
if config.AWSStsConfig == nil {
return middlewares, nil
}
if config.RemoteURL == "" {
return nil, fmt.Errorf("AWS STS middleware requires a remote URL: SigV4 signing is only meaningful for remote MCP servers")
}
awsStsParams := awssts.MiddlewareParams{
AWSStsConfig: config.AWSStsConfig,
TargetURL: config.RemoteURL, // Use remote URL as the target for SigV4 signing
}
awsStsMwConfig, err := types.NewMiddlewareConfig(awssts.MiddlewareType, awsStsParams)
if err != nil {
return nil, fmt.Errorf("failed to create AWS STS middleware config: %w", err)
}
return append(middlewares, *awsStsMwConfig), nil
}
// prependOriginMiddleware prepends Origin-header validation middleware for
// DNS-rebind protection per MCP 2025-11-25 §"Security Warning". It is placed at
// the front of the chain so disallowed Origin values are rejected before
// authentication or any business logic runs. Default-derivation logic lives in
// origin.ResolveAllowedOrigins so the standalone `thv proxy` command and the
// runner path agree on behavior.
//
// This is called from runner.Run after both middleware-population paths
// (PopulateMiddlewareConfigs and WithMiddlewareFromFlags) have run, because
// that is the only point where the effective Host/Port/AllowedOrigins are
// fully resolved — the CLI builder defers port resolution to validateConfig.
//
// When the effective allowlist is empty — which happens when the operator
// binds to a non-loopback host without supplying --allowed-origins — the
// middleware is skipped entirely and a WARN is logged so the security-disabled
// state is visible in operator logs. A follow-up PR hardens the non-loopback
// path by requiring an explicit opt-in flag (see audit row 22).
func prependOriginMiddleware(middlewares []types.MiddlewareConfig, config *RunConfig) ([]types.MiddlewareConfig, error) {
allowed := origin.ResolveAllowedOrigins(config.Host, config.Port, config.AllowedOrigins)
if len(allowed) == 0 {
slog.Warn("Origin validation disabled — no allowlist configured for non-loopback bind",
"host", config.Host,
"port", config.Port,
"hint", "pass --allowed-origins=https://your-client.example to enable DNS-rebind protection",
)
return middlewares, nil
}
params := origin.MiddlewareParams{AllowedOrigins: allowed}
mwCfg, err := types.NewMiddlewareConfig(origin.MiddlewareType, params)
if err != nil {
return nil, fmt.Errorf("failed to create origin middleware config: %w", err)
}
// Prepend so Origin validation is the outermost wrapper (runs first at
// request time). Build a new slice to avoid mutating the caller's backing
// array.
return append([]types.MiddlewareConfig{*mwCfg}, middlewares...), nil
}
// addRateLimitMiddleware adds rate limit middleware if configured.
func addRateLimitMiddleware(middlewares []types.MiddlewareConfig, config *RunConfig) ([]types.MiddlewareConfig, error) {
if config.RateLimitConfig == nil {
return middlewares, nil
}
if config.ScalingConfig == nil || config.ScalingConfig.SessionRedis == nil {
return nil, fmt.Errorf("rate limiting requires sessionStorage with provider redis")
}
redisAddr := config.ScalingConfig.SessionRedis.Address
redisDB := config.ScalingConfig.SessionRedis.DB
params := ratelimit.MiddlewareParams{
Namespace: config.RateLimitNamespace,
ServerName: config.Name,
Config: config.RateLimitConfig,
RedisAddr: redisAddr,
RedisDB: redisDB,
}
mwConfig, err := types.NewMiddlewareConfig(ratelimit.MiddlewareType, params)
if err != nil {
return nil, fmt.Errorf("failed to create rate limit middleware config: %w", err)
}
return append(middlewares, *mwConfig), nil
}