Skip to content

Commit 9cc163a

Browse files
yroblataskbot
andauthored
Populate LLMSetupNote for Gemini CLI to warn on --tls-skip-verify no-op (#5188)
Fix unknown field LLMSetupNote in clientAppConfig The field was used in the GeminiCli struct literal but never defined on clientAppConfig. Move the note into warnTLSSkipVerify in pkg/llm/setup.go as a gemini-cli-specific branch, which already handles per-tool TLS warnings. Closes #5180 Co-authored-by: taskbot <taskbot@users.noreply.github.com>
1 parent 46c08c5 commit 9cc163a

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

pkg/llm/setup.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -283,9 +283,16 @@ func warnTLSSkipVerify(errOut io.Writer, skip bool, configured []ToolConfig) {
283283
"(LLM provider APIs, MCP registry, etc.), not just the LLM gateway. "+
284284
"Use only in isolated local environments.\n", tc.Tool, tc.Tool)
285285
case "proxy":
286-
_, _ = fmt.Fprintf(errOut,
287-
"Warning: %s uses proxy mode — TLS certificate verification is disabled for the "+
288-
"proxy's upstream gateway connection only. Use only in isolated local environments.\n", tc.Tool)
286+
if tc.Tool == "gemini-cli" {
287+
_, _ = fmt.Fprintf(errOut,
288+
"Note: --tls-skip-verify is not supported for Gemini CLI "+
289+
"(setting NODE_TLS_REJECT_UNAUTHORIZED would affect all HTTPS connections in the process). "+
290+
"Ensure your proxy certificate is trusted by the system store instead.\n")
291+
} else {
292+
_, _ = fmt.Fprintf(errOut,
293+
"Warning: %s uses proxy mode — TLS certificate verification is disabled for the "+
294+
"proxy's upstream gateway connection only. Use only in isolated local environments.\n", tc.Tool)
295+
}
289296
}
290297
}
291298
}

0 commit comments

Comments
 (0)