Use mainBranchName and testAuthorEmail constants in git tests

Replace raw "main" and "test@example.com" string literals with the
existing/new named constants to fix the remaining goconst violations.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: reyortiz3

pkg/git/client_test.go

@@ -33,10 +33,10 @@ func TestDefaultGitClient_Clone_Errors(t *testing.T) {
 		config CloneConfig
 	}{
 		{name: "invalid URL", config: CloneConfig{URL: "invalid-url"}},
-		{name: "conflicting branch and tag", config: CloneConfig{URL: testRepoURL, Branch: "main", Tag: "v1.0"}},
-		{name: "conflicting branch and commit", config: CloneConfig{URL: testRepoURL, Branch: "main", Commit: testCommitHash}},
+		{name: "conflicting branch and tag", config: CloneConfig{URL: testRepoURL, Branch: mainBranchName, Tag: "v1.0"}},
+		{name: "conflicting branch and commit", config: CloneConfig{URL: testRepoURL, Branch: mainBranchName, Commit: testCommitHash}},
 		{name: "conflicting tag and commit", config: CloneConfig{URL: testRepoURL, Tag: "v1.0", Commit: testCommitHash}},
-		{name: "all three refs set", config: CloneConfig{URL: testRepoURL, Branch: "main", Tag: "v1.0", Commit: testCommitHash}},
+		{name: "all three refs set", config: CloneConfig{URL: testRepoURL, Branch: mainBranchName, Tag: "v1.0", Commit: testCommitHash}},
 	}
 
 	for _, tt := range tests {
@@ -171,13 +171,13 @@ func TestCloneConfig_Validate(t *testing.T) {
 		wantErr bool
 	}{
 		{name: "URL only", config: CloneConfig{URL: testRepoURL}, wantErr: false},
-		{name: "branch only", config: CloneConfig{URL: "u", Branch: "main"}, wantErr: false},
+		{name: "branch only", config: CloneConfig{URL: "u", Branch: mainBranchName}, wantErr: false},
 		{name: "tag only", config: CloneConfig{URL: "u", Tag: "v1"}, wantErr: false},
 		{name: "commit only", config: CloneConfig{URL: "u", Commit: testShortHash}, wantErr: false},
-		{name: "branch+tag", config: CloneConfig{URL: "u", Branch: "main", Tag: "v1"}, wantErr: true},
-		{name: "branch+commit", config: CloneConfig{URL: "u", Branch: "main", Commit: testShortHash}, wantErr: true},
+		{name: "branch+tag", config: CloneConfig{URL: "u", Branch: mainBranchName, Tag: "v1"}, wantErr: true},
+		{name: "branch+commit", config: CloneConfig{URL: "u", Branch: mainBranchName, Commit: testShortHash}, wantErr: true},
 		{name: "tag+commit", config: CloneConfig{URL: "u", Tag: "v1", Commit: testShortHash}, wantErr: true},
-		{name: "all three", config: CloneConfig{URL: "u", Branch: "main", Tag: "v1", Commit: testShortHash}, wantErr: true},
+		{name: "all three", config: CloneConfig{URL: "u", Branch: mainBranchName, Tag: "v1", Commit: testShortHash}, wantErr: true},
 	}
 
 	for _, tt := range tests {

pkg/git/integration_test.go

@@ -15,7 +15,10 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-const mainBranchName = "main"
+const (
+	mainBranchName  = "main"
+	testAuthorEmail = "test@example.com"
+)
 
 // initTestRepo creates a local git repo with an initial commit containing the given files.
 // Returns the repo directory path.
@@ -36,7 +39,7 @@ func initTestRepo(t *testing.T, files map[string]string) string {
 	}
 
 	_, err = wt.Commit("Initial commit", &gogit.CommitOptions{
-		Author: &object.Signature{Name: testAuthorName, Email: "test@example.com"},
+		Author: &object.Signature{Name: testAuthorName, Email: testAuthorEmail},
 	})
 	require.NoError(t, err)
 
@@ -99,7 +102,7 @@ func TestDefaultGitClient_CloneWithBranch(t *testing.T) {
 	_, err = wt.Add("feature.txt")
 	require.NoError(t, err)
 	_, err = wt.Commit("Add feature", &gogit.CommitOptions{
-		Author: &object.Signature{Name: testAuthorName, Email: "test@example.com"},
+		Author: &object.Signature{Name: testAuthorName, Email: testAuthorEmail},
 	})
 	require.NoError(t, err)
 
@@ -142,7 +145,7 @@ func TestDefaultGitClient_CloneWithTag(t *testing.T) {
 	_, err = wt.Add("v2.txt")
 	require.NoError(t, err)
 	_, err = wt.Commit("Post-tag commit", &gogit.CommitOptions{
-		Author: &object.Signature{Name: testAuthorName, Email: "test@example.com"},
+		Author: &object.Signature{Name: testAuthorName, Email: testAuthorEmail},
 	})
 	require.NoError(t, err)
 
@@ -186,7 +189,7 @@ func TestDefaultGitClient_CloneWithCommit(t *testing.T) {
 	_, err = wt.Add("file2.txt")
 	require.NoError(t, err)
 	_, err = wt.Commit("Second commit", &gogit.CommitOptions{
-		Author: &object.Signature{Name: testAuthorName, Email: "test@example.com"},
+		Author: &object.Signature{Name: testAuthorName, Email: testAuthorEmail},
 	})
 	require.NoError(t, err)