Description
If _parseJson (and internal JSON.parse) throws an error, it will not be passed to reject, so outer getMappedLocation (and StackTrace.fromError from stacktrace-js) will never resolve/reject.
https://github.com/stacktracejs/stacktrace-gps/blob/v3.0.4/stacktrace-gps.js#L240-L251
var sourceMapConsumerPromise = new Promise(function(resolve, reject) {
return this._get(sourceMappingURL).then(function(sourceMapSource) {
if (typeof sourceMapSource === 'string') {
// throws from here vvv
sourceMapSource = _parseJson(sourceMapSource.replace(/^\)\]\}'/, ''));
}
if (typeof sourceMapSource.sourceRoot === 'undefined') {
sourceMapSource.sourceRoot = defaultSourceRoot;
}
resolve(new SourceMap.SourceMapConsumer(sourceMapSource));
}, reject); //<- not caught in here
}.bind(this));Expected Behavior
Invalid source map errors can be caught by StackTrace.fromError(...).catch an others.
Current Behavior
Error becomes unhandled rejection and can not be caught.
Steps to Reproduce
Try to getMappedLocation for source map with some invalid JSON content (for example <html).
Context
I'm trying to catch every possible error with addEventListener('error' and addEventListener('unhandledrejection', enhance stack trace and send it to server. Currently, server is configured to respond with index.html for non-exiting paths. If .map file is missing for some reason, stacktrace-js receives some HTML instead of JSON, fails and no error is sent at all.
What is worse, this unhandled rejection is caught by 'unhandledrejection' handler and passed it to StackTrace.fromError again, which results in an infinite loop.
Your Environment
- stacktrace.js version: 2.0.2
- Browser Name and version: Chromium 80.0.3987.116
- Operating System and version: Arch Linux (desktop)
- Link to your project: it is private
Possible Solution
- return this._get(sourceMappingURL).then(..., reject);
+ return this._get(sourceMappingURL).then(...).catch(reject);