Merge pull request #496 from stakpak/fix/strip-unsupported-params-for-reasoning-models

fix(openai): strip unsupported params for reasoning models & minor cleanups

Author: ahmedhesham6

cli/Cargo.toml

@@ -15,7 +15,7 @@ stakpak-mcp-client = { workspace = true }
 stakpak-mcp-proxy = { workspace = true }
 stakpak-tui = { workspace = true }
 stakpak-shared = { workspace = true }
-stakai = { path = "../libs/ai" }
+stakai = { workspace = true }
 tracing = { workspace = true }
 tracing-subscriber = { workspace = true }
 rmcp = { workspace = true }

libs/ai/src/providers/openai/convert.rs

@@ -546,13 +546,25 @@ pub fn to_responses_request(req: &GenerateRequest, stream: bool) -> ResponsesReq
         None
     };
 
+    // Reasoning models don't support temperature or top_p
+    let temperature = if is_reasoning {
+        None
+    } else {
+        req.options.temperature
+    };
+    let top_p = if is_reasoning {
+        None
+    } else {
+        req.options.top_p
+    };
+
     ResponsesRequest {
         model: req.model.id.clone(),
         input,
         instructions: None, // System message is in input array
         max_output_tokens: req.options.max_tokens,
-        temperature: req.options.temperature,
-        top_p: req.options.top_p,
+        temperature,
+        top_p,
         stream: Some(stream),
         tools,
         tool_choice,
@@ -1054,4 +1066,39 @@ mod tests {
         let tool_result = tool_result.unwrap();
         assert_eq!(tool_result["call_id"], "call_123");
     }
+
+    // =========================================================================
+    // Temperature / Top-P Filtering Tests
+    // =========================================================================
+
+    #[test]
+    fn test_responses_request_strips_temperature_for_reasoning_model() {
+        let mut req = make_request(
+            "gpt-5.2-2025-12-11",
+            Some(ProviderOptions::OpenAI(OpenAIOptions::responses())),
+        );
+        req.options.temperature = Some(0.7);
+        req.options.top_p = Some(0.9);
+
+        let responses_req = to_responses_request(&req, false);
+
+        // Reasoning models must not send temperature or top_p
+        assert!(responses_req.temperature.is_none());
+        assert!(responses_req.top_p.is_none());
+    }
+
+    #[test]
+    fn test_responses_request_keeps_temperature_for_standard_model() {
+        let mut req = make_request(
+            "gpt-4o",
+            Some(ProviderOptions::OpenAI(OpenAIOptions::responses())),
+        );
+        req.options.temperature = Some(0.7);
+        req.options.top_p = Some(0.9);
+
+        let responses_req = to_responses_request(&req, false);
+
+        assert_eq!(responses_req.temperature, Some(0.7));
+        assert_eq!(responses_req.top_p, Some(0.9));
+    }
 }

libs/ai/src/providers/stakpak/provider.rs

@@ -118,7 +118,7 @@ impl Provider for StakpakProvider {
         // with stakpak/{provider}/ prefix for routing
         use crate::registry::models_dev::load_models_for_provider;
 
-        const PROVIDERS: &[&str] = &["anthropic", "openai", "google"];
+        const PROVIDERS: &[&str] = &["anthropic", "openai" /*, "google" */];
 
         let mut models = Vec::new();