Skip to content

Commit 29e2844

Browse files
committed
Amend previous commit
* Add changelog entry * For consistency, always use `.snupkg` format (for local builds, too) * Add missing `NUnit` package reference to a NUnit test project
1 parent 8b13837 commit 29e2844

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Breaking Changes:
99
Enhancements:
1010
- Minimally improved support for methods having `ref struct` parameter and return types, such as `Span<T>`: Intercepting such methods caused the runtime to throw `InvalidProgramException` and `NullReferenceException` due to forbidden conversions of `ref struct` values when transferring them into & out of `IInvocation` instances. To prevent these exceptions from being thrown, such values now get replaced with `null` in `IInvocation`, and with `default` values in return values and `out` arguments. When proceeding to a target, the target methods likewise receive such nullified values. (@stakx, #665)
1111
- Restore ability on .NET 9 and later to save dynamic assemblies to disk using `PersistentProxyBuilder` (@stakx, #718)
12+
- Configure SourceLink & `.snupkg` symbols package format (@Romfos, #722)
1213
- Dependencies were updated
1314

1415
Bugfixes:

buildscripts/common.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
<BuildVersionMajor>$(BuildVersion.Split('.')[0])</BuildVersionMajor>
1313
<BuildVersionNoSuffix>$(BuildVersion.Split('-')[0])</BuildVersionNoSuffix>
1414
<GenerateDocumentationFile>true</GenerateDocumentationFile>
15+
<IncludeSymbols>true</IncludeSymbols>
16+
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
1517
</PropertyGroup>
1618

1719
<PropertyGroup>
@@ -37,8 +39,6 @@
3739
<!--Deterministic Build and Source Link settings -->
3840
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
3941
<EmbedUntrackedSources>true</EmbedUntrackedSources>
40-
<IncludeSymbols>true</IncludeSymbols>
41-
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
4242
</PropertyGroup>
4343

4444
<ItemGroup>

src/Castle.Core.Tests.WeakNamed/Castle.Core.Tests.WeakNamed.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
<ItemGroup>
2525
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
2626
<PackageReference Include="NUnit3TestAdapter" Version="6.0.1" />
27+
<PackageReference Include="NUnit" Version="3.14.0" />
2728
</ItemGroup>
2829

2930
<ItemGroup>

src/Castle.Core.Tests/Castle.Core.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
</ItemGroup>
5757

5858
<ItemGroup Condition=" '$(TargetFrameworkIdentifier)' != '.NETFramework' ">
59-
<PackageReference Include="System.Diagnostics.EventLog" Version="8.0.2" />
59+
<PackageReference Include="System.Diagnostics.EventLog" Version="8.0.2" />
6060
<PackageReference Include="System.Security.Permissions" Version="8.0.0" />
6161
<PackageReference Include="PublicApiGenerator" Version="11.5.4" />
6262
</ItemGroup>

0 commit comments

Comments
 (0)