fix(ability): adds additional check to rulesToFields

Function should ignore rules without conditions as well

Author: stalniy

packages/casl-ability/spec/rules_to_fields.spec.js

@@ -18,6 +18,13 @@ describe('rulesToFields', () => {
     expect(object).to.be.an('object').and.empty
   })
 
+  it('returns an empty object for `Ability` instance with rules without conditions', () => {
+    const ability = AbilityBuilder.define(can => can('read', 'Post'))
+    const object = rulesToFields(ability, 'read', 'Post')
+
+    expect(object).to.be.an('object').and.empty
+  })
+
   it('extracts field values from direct rule conditions', () => {
     const ability = AbilityBuilder.define((can) => {
       can('read', 'Post', { id: 5 })

packages/casl-ability/src/extra.js

@@ -30,7 +30,7 @@ export function rulesToQuery(ability, action, subject, convert) {
 
 export function rulesToFields(ability, action, subject) {
   return ability.rulesFor(action, subject)
-    .filter(rule => !rule.inverted)
+    .filter(rule => !rule.inverted && rule.conditions)
     .reduce((values, rule) => {
       return Object.keys(rule.conditions).reduce((fields, fieldName) => {
         const value = rule.conditions[fieldName];