attribution defined in local config isn't used

[almccon]

For the MapLibre renderer, it appears that any attribution string we define in config files is not being used, or maybe it is but it's being overridden by attribution from the style's tilejson. I noticed this because in the Stadia Maps style in our gh.pages.js config (here

maperture/public/config/gh-pages.js

Line 14 in 7f0f203

'&copy; <a href="https://stamen.com/" target="_blank">Stamen Design</a> &copy; <a href="https://www.openstreetmap.org/about/" target="_blank">OpenStreetMap contributors</a>',

) we have slightly different wording than what we are seeing rendered on the map. Instead, what we get is the attribution coming from the tilejson associated with those styles: https://tiles.stadiamaps.com/data/stamen-omt.json

For me the expected behavior would be for the attribution I define in the config to override the one coming from the tiles. (In the specific case of our Stadia demos it doesn't matter really, either attribution is fine and they're effectively the same.)

Also, it looks like the attribution we define for styles that use Leaflet aren't showing up at all. At least on the gh-pages demo.

[ebrelsford]

This is also an issue with leaflet styles. We should think through the UX with attribution since enabling leaflet attribution locally led to overlapping attribution boxes (both on the lower right of the screen). Maybe defaulting to a closed (i) button for all attribution makes sense?

[almccon]

Defaulting to closed seems reasonable. Would that still mean the closed button would be overlapping so that you wouldn't always be able to expand one of them?

[ebrelsford]

Hopefully they wouldn't be overlapping!

Maybe we could add something here to keep all the info about the map style in one place?

[kelsey-taylor]

i like the idea of adding an info button next to the style name that is hoverable/clickable and has the attribution info for the style there!