-
Notifications
You must be signed in to change notification settings - Fork 1
Description
I reviewed the proposed integration of KiTrack into the STAR framework as implemented in this repository https://github.com/klendathu2k/stroot-forward-tracker/tree/master/StRoot/StgUtil and here are a few comments:
-
Hiding selected code (without the license, credits, and history) from the KiTrack package in StRoot/StgUtil does not look to me as a good idea. KiTrack seems well maintained and can be installed by itself with CMake. Perhaps, we should include it as an external package into our CMake-base STAR build.
-
The differences between KiTrack and the proposed StRoot/StgUtil seem minor and I am not sure about their value. It is more valuable if we base our work on the official KiTrack release
-
I agree that for our purposes KiTrack does not need to depend on other packages in iLCSoft. It looks that this dependency can be easily broken and I will make the appropriate changes in this fork