Fix: simplify insert (#281)

simplify insert

cleaner unsized_list

Author: stegaBOB

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Reduced unsized map CU cost by 50% when key already exists (#281)
+- Use full result path in unsized_type proc macro (#281)
+
 ## [0.26.1] - 2025-10-02
 
 ### Fixed

star_frame/src/unsize/impls/unsized_list.rs

@@ -282,8 +282,8 @@ where
                         })?;
 
                     for item in rest.iter_mut() {
-                        item.as_mut_offset().0 =
-                            unsafe { item.as_mut_offset().0.unchecked_sub(change) }
+                        let item = item.as_mut_offset();
+                        item.0 = unsafe { item.0.unchecked_sub(change) };
                     }
                 }
             }
@@ -301,8 +301,8 @@ where
                         })?;
 
                     for item in rest.iter_mut() {
-                        item.as_mut_offset().0 =
-                            unsafe { item.as_mut_offset().0.unchecked_add(change) }
+                        let item = item.as_mut_offset();
+                        item.0 = unsafe { item.0.unchecked_add(change) };
                     }
                 }
             }

star_frame/src/unsize/impls/unsized_map.rs

@@ -13,7 +13,7 @@ use crate::{
             UnsizedListWithOffsetIterMut,
         },
         init::UnsizedInit,
-        FromOwned,
+        FromOwned, UnsizedTypeMut,
     },
 };
 use std::{collections::BTreeMap, iter::FusedIterator};
@@ -189,12 +189,13 @@ where
     pub fn insert<I>(&mut self, key: K, value: I) -> Result<bool>
     where
         V: UnsizedInit<I>,
+        V::Mut<'top>: UnsizedTypeMut<UnsizedType = V>,
     {
         match self.get_index(&key) {
             Ok(existing_index) => {
-                // TODO: optimize this by just modifying bytes to fit and then writing to them
-                self.list().remove(existing_index)?;
-                self.list().insert_with_offset(existing_index, value, key)?;
+                let mut list = self.list();
+                let mut item = list.index_exclusive(existing_index)?;
+                item.set_from_init(value)?;
                 Ok(false)
             }
             Err(insertion_index) => {

star_frame_proc/src/unsize/struct_impl.rs

@@ -654,7 +654,7 @@ impl UnsizedStructContext {
         if self.args.owned_type.is_some() {
             return None;
         }
-        Paths!(prelude, default);
+        Paths!(prelude, default, result);
         UnsizedStructContext!(self => struct_type, sized_field_idents, unsized_field_types, unsized_field_idents, sized_type);
 
         let from_owned_generics =
@@ -694,7 +694,7 @@ impl UnsizedStructContext {
                 }
 
                 #[inline]
-                fn from_owned(owned: Self::Owned, bytes: &mut &mut [u8]) -> Result<usize> {
+                fn from_owned(owned: Self::Owned, bytes: &mut &mut [u8]) -> #result<usize> {
                     let size = {
                         #sized_from_owned #(<#unsized_field_types as #prelude::FromOwned>::from_owned(owned.#unsized_field_idents, bytes)? +)* 0
                     };