Handle DELETE method in ReadSignals (#7)

bencroker · SpiralOSS · web-flow · commit 1b06c5968c9a · 2026-04-16T12:57:56.000-04:00
* Handle DELETE method in `ReadSignals`

* Refactor ReadSignalsToJsonDocument method logic

* DELETE taken from System.Net.Http.HttpMethod

* nuget version bumps to 1.3

---------

Co-authored-by: Greg Holden &lt;SpiralOSS@users.noreply.github.com&gt;
diff --git a/examples/csharp/HelloWorld/wwwroot/hello-world.html b/examples/csharp/HelloWorld/wwwroot/hello-world.html
@@ -3,7 +3,7 @@
 <head>
     <title>Datastar SDK Demo</title>
     <script src="https://unpkg.com/@tailwindcss/browser@4"></script>
-    <script src="https://cdn.jsdelivr.net/gh/starfederation/datastar@1.0.0-RC.8/bundles/datastar.js" type="module"></script>
+    <script src="https://cdn.jsdelivr.net/gh/starfederation/datastar@1.0.0/bundles/datastar.js" type="module"></script>
 </head>
 <body class="bg-white dark:bg-gray-900 text-lg  my-16">
 
@@ -72,4 +72,4 @@ <h1 class="text-gray-900 dark:text-white text-3xl font-semibold">
     </div>
 </div>
 </body>
-</html>
+</html>
diff --git a/src/csharp/ModelBinding/SignalsModelBinder.cs b/src/csharp/ModelBinding/SignalsModelBinder.cs
@@ -67,7 +67,9 @@ public async Task BindModelAsync(ModelBindingContext bindingContext)
 
     private async ValueTask<JsonDocument> ReadSignalsToJsonDocument(ModelBindingContext bindingContext)
     {
-        return bindingContext.HttpContext.Request.Method == WebRequestMethods.Http.Get
+        var method = bindingContext.HttpContext.Request.Method;
+
+        return method == WebRequestMethods.Http.Get || method == HttpMethod.Delete.Method
             ? JsonDocument.Parse(await signalsReader.ReadSignalsAsync() ?? string.Empty)
             : await JsonDocument.ParseAsync(signalsReader.GetSignalsStream());
     }
@@ -80,4 +82,4 @@ public class SignalsModelBinderProvider : IModelBinderProvider
             ? new BinderTypeModelBinder(typeof(SignalsModelBinder))
             : null;
 
-}
+}
diff --git a/src/csharp/StarFederation.Datastar.csproj b/src/csharp/StarFederation.Datastar.csproj
@@ -20,7 +20,7 @@
 
         <!-- NuGet config -->
         <PackageId>StarFederation.Datastar</PackageId>
-        <PackageVersion>1.2.1</PackageVersion>
+        <PackageVersion>1.3</PackageVersion>
         <PackageTags>datastar;datastar-sharp;fsharp;functional;asp.net core;asp.net;.net core;routing;web;csharp</PackageTags>
         <PackageProjectUrl>https://github.com/starfederation/datastar-dotnet</PackageProjectUrl>
         <PackageIcon>datastar_icon.png</PackageIcon>
diff --git a/src/fsharp/ServerSentEventGenerator.fs b/src/fsharp/ServerSentEventGenerator.fs
@@ -134,7 +134,7 @@ type ServerSentEventGenerator(httpContextAccessor:IHttpContextAccessor) =
 
     static member GetSignalsStream(httpRequest:HttpRequest) =
         match httpRequest.Method with
-        | System.Net.WebRequestMethods.Http.Get ->
+        | method when method = System.Net.WebRequestMethods.Http.Get || method = System.Net.Http.HttpMethod.Delete.Method ->
             match httpRequest.Query.TryGetValue(Consts.DatastarKey) with
             | true, stringValues when stringValues.Count > 0 -> (new MemoryStream(Encoding.UTF8.GetBytes(stringValues[0])) :> Stream)
             | _ -> Stream.Null
@@ -143,7 +143,7 @@ type ServerSentEventGenerator(httpContextAccessor:IHttpContextAccessor) =
     static member ReadSignalsAsync(httpRequest:HttpRequest, cancellationToken:CancellationToken) =
         backgroundTask {
             match httpRequest.Method with
-            | System.Net.WebRequestMethods.Http.Get ->
+            | method when method = System.Net.WebRequestMethods.Http.Get || method = System.Net.Http.HttpMethod.Delete.Method ->
                 match httpRequest.Query.TryGetValue(Consts.DatastarKey) with
                 | true, stringValues when stringValues.Count > 0 -> return stringValues[0]
                 | _ -> return Signals.empty
@@ -159,7 +159,7 @@ type ServerSentEventGenerator(httpContextAccessor:IHttpContextAccessor) =
         task {
             try
                 match httpRequest.Method with
-                | System.Net.WebRequestMethods.Http.Get ->
+                | method when method = System.Net.WebRequestMethods.Http.Get || method = System.Net.Http.HttpMethod.Delete.Method ->
                     match httpRequest.Query.TryGetValue(Consts.DatastarKey) with
                     | true, stringValues when stringValues.Count > 0 ->
                         return ValueSome (JsonSerializer.Deserialize<'T>(stringValues[0], jsonSerializerOptions))
diff --git a/src/fsharp/StarFederation.Datastar.FSharp.fsproj b/src/fsharp/StarFederation.Datastar.FSharp.fsproj
@@ -22,7 +22,7 @@
 
         <!-- NuGet config -->
         <PackageId>StarFederation.Datastar.FSharp</PackageId>
-        <PackageVersion>1.2.1</PackageVersion>
+        <PackageVersion>1.3</PackageVersion>
         <PackageTags>datastar;datastar-sharp;fsharp;functional;asp.net core;asp.net;.net core;routing;web</PackageTags>
         <PackageProjectUrl>https://github.com/starfederation/datastar-dotnet</PackageProjectUrl>
         <PackageIcon>datastar_icon.png</PackageIcon>

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,9 @@ public async Task BindModelAsync(ModelBindingContext bindingContext)`
`67`	`67`
`68`	`68`	`private async ValueTask<JsonDocument> ReadSignalsToJsonDocument(ModelBindingContext bindingContext)`
`69`	`69`	`{`
`70`		`- return bindingContext.HttpContext.Request.Method == WebRequestMethods.Http.Get`
	`70`	`+ var method = bindingContext.HttpContext.Request.Method;`
	`71`	`+`
	`72`	`+ return method == WebRequestMethods.Http.Get \|\| method == HttpMethod.Delete.Method`
`71`	`73`	`? JsonDocument.Parse(await signalsReader.ReadSignalsAsync() ?? string.Empty)`
`72`	`74`	`: await JsonDocument.ParseAsync(signalsReader.GetSignalsStream());`
`73`	`75`	`}`
`@@ -80,4 +82,4 @@ public class SignalsModelBinderProvider : IModelBinderProvider`
`80`	`82`	`? new BinderTypeModelBinder(typeof(SignalsModelBinder))`
`81`	`83`	`: null;`
`82`	`84`
`83`		`-}`
	`85`	`+}`