fetch not exiting upon element destruction

[goertzenator]

Bug Report

I see that rc6 has new code to abort fetches when the owning element goes away, but it seems to not be working in my application. I did some code tracing and found...

1. The observe call is being made.
2. Before the connection even gets rolling, the observer is disconnected by this call
3. And 2 explains why the callback is never invoked.

edit: Misinterpreted observations, ignore.

It is worth noting that in my application the parent element is destroyed at the same time as the fetching element. I will look at this more tomorrow, but wanted to get these findings posted today.

Datastar Version

v1.0.0-rc6

[bencroker]

Are you sure? We have a passing test for this at https://data-star.dev/tests/fetch_cancel_on_element_removal

[goertzenator]

I could review the test if you like (if it is public, I don't know where it is).

Looking at code... should there be a return or await on this line?

[bencroker]

As I said, we have a passing test. Please show an example of it not working, so I can troubleshoot.

[goertzenator]

I set out to make a minimal example demonstrating the issue, and .... I couldn't make it fail.

My production app still fails though. Some context that I didn't give yet is that I have Datastar running within a React component. This seems to work really well, but that MutationObserver in the fetch just will not trigger when React disposes of the component.

I assume this is something strange that React is doing. I've started messing with shadow DOMs but that hasn't helped. I will continue to play with this.

Anyway, this bug is not valid and could be closed.

[bencroker]

It turns out request are not aborted if one of their ancestors are removed from the DOM, rather than the element directly, which is likely what you’re seeing.

Follow the PR at #1080