Skip to content

Commit 186ff5f

Browse files
committed
refactor: return immediately
1 parent 13cfd2d commit 186ff5f

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

Diff for: src/aes/generateAESKey.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@ export default async function generateAESKey(alg: string, extractable: boolean,
44
const length = parseInt(alg.slice(1, 4), 10);
55
const isGCM = (alg.slice(-3) == 'GCM' || alg.slice(-5, 3) == 'GCM');
66

7-
let key = await subtle.generateKey({
7+
return await subtle.generateKey({
88
name: (isGCM) ? 'AES-GCM' : 'AES-KW',
99
length
1010
}, extractable, keyUsages);
11-
12-
return key;
1311
}

Diff for: src/ecdsa/generateECDSAKey.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@ const { subtle } = require('node:crypto').webcrypto;
33
import getCurve from "./getCurve";
44

55
export default async function generateECDSAKey(alg: string, extractable: boolean) {
6-
let key = await subtle.generateKey({
6+
return await subtle.generateKey({
77
name: 'ECDSA',
88
namedCurve: getCurve(alg)
99
}, extractable, ['sign', 'verify']);
10-
11-
return key;
1210
}

Diff for: src/hmac/generateHMACKey.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,9 @@ export default async function generateHMACKey(alg: string, extractable: boolean,
55

66
let hash = { name: `SHA-${length}` };
77

8-
let key = await subtle.generateKey({
8+
return await subtle.generateKey({
99
name: 'HMAC',
1010
hash,
1111
length
1212
}, extractable, keyUsages);
13-
14-
return key;
1513
}

Diff for: src/rsa/generateRSAKey.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const { subtle } = require('node:crypto').webcrypto;
33
import getRSAType from "./getRSAType";
44

55
function getHashType(alg: string) {
6-
const length = parseInt(alg.substr(-3), 10);
6+
const length = parseInt(alg.slice(-3), 10);
77

88
if (isNaN(length)) return 'SHA-1';
99

@@ -28,12 +28,10 @@ export default async function generateRSAKey(alg: string, extractable: boolean)
2828

2929
const keyUsages = getKeyUsages(RSAType);
3030

31-
let key = await subtle.generateKey({
31+
return await subtle.generateKey({
3232
name: RSAType,
3333
modulusLength: 2048,
3434
publicExponent: new Uint8Array([1, 0, 1]),
3535
hash: getHashType(alg),
3636
}, extractable, keyUsages);
37-
38-
return key;
3937
}

0 commit comments

Comments
 (0)