Skip to content

Commit 69807a1

Browse files
committed
Fixed issue with sort instability of use statements. (#7440)
1 parent 41dabb0 commit 69807a1

File tree

19 files changed

+87
-93
lines changed

19 files changed

+87
-93
lines changed

corelib/src/array.cairo

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,15 @@
6161
//!
6262
//! [`append`]: ArrayTrait::append
6363

64-
use crate::box::BoxTrait;
65-
use crate::iter::Iterator;
66-
use crate::metaprogramming::TypeEqual;
67-
use crate::serde::Serde;
6864
use crate::RangeCheck;
65+
use crate::box::BoxTrait;
6966
#[allow(unused_imports)]
7067
use crate::gas::withdraw_gas;
68+
use crate::iter::Iterator;
69+
use crate::metaprogramming::TypeEqual;
7170
#[allow(unused_imports)]
7271
use crate::option::OptionTrait;
72+
use crate::serde::Serde;
7373
#[feature("deprecated-index-traits")]
7474
use crate::traits::IndexView;
7575
/// A collection of elements of the same type contiguous in memory.

corelib/src/byte_array.cairo

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,18 @@
4343
//! ```
4444

4545
use crate::array::{ArrayTrait, SpanTrait};
46-
use crate::clone::Clone;
47-
use crate::cmp::min;
48-
use crate::traits::{Into, TryInto};
4946
#[allow(unused_imports)]
5047
use crate::bytes_31::{
5148
BYTES_IN_BYTES31, Bytes31Trait, POW_2_128, POW_2_8, U128IntoBytes31, U8IntoBytes31,
5249
one_shift_left_bytes_felt252, one_shift_left_bytes_u128, split_u128, u8_at_u256,
5350
};
51+
use crate::clone::Clone;
52+
use crate::cmp::min;
5453
#[allow(unused_imports)]
5554
use crate::integer::{U32TryIntoNonZero, u128_safe_divmod};
5655
#[allow(unused_imports)]
5756
use crate::serde::Serde;
57+
use crate::traits::{Into, TryInto};
5858
#[allow(unused_imports)]
5959
use crate::zeroable::NonZeroIntoImpl;
6060

corelib/src/bytes_31.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
//! assert!(value[0] == 0xbb);
1515
//! ```
1616

17-
use crate::traits::{Into, TryInto};
1817
use crate::RangeCheck;
1918
#[allow(unused_imports)]
2019
use crate::integer::{u128_safe_divmod, u128_to_felt252};
2120
#[allow(unused_imports)]
2221
use crate::option::OptionTrait;
22+
use crate::traits::{Into, TryInto};
2323

2424
pub(crate) const BYTES_IN_BYTES31: usize = 31;
2525
const BYTES_IN_U128: usize = 16;

corelib/src/circuit.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,8 +764,8 @@ extern fn get_circuit_output<C, Output>(
764764
/// Helper module to convert into `u384`.
765765
mod conversions {
766766
use crate::integer::{downcast, upcast};
767-
use crate::internal::bounded_int::{AddHelper, BoundedInt, DivRemHelper, MulHelper, UnitInt};
768767
use crate::internal::bounded_int;
768+
use crate::internal::bounded_int::{AddHelper, BoundedInt, DivRemHelper, MulHelper, UnitInt};
769769
use super::{u384, u96};
770770

771771
const POW128: felt252 = 0x100000000000000000000000000000000;

corelib/src/ec.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@
5151
//! let _result = state.finalize();
5252
//! ```
5353

54-
use crate::zeroable::IsZeroResult;
5554
use crate::RangeCheck;
5655
#[allow(unused_imports)]
5756
use crate::array::ArrayTrait;
5857
#[allow(unused_imports)]
5958
use crate::traits::{Into, TryInto};
59+
use crate::zeroable::IsZeroResult;
6060

6161
pub mod stark_curve {
6262
/// The STARK Curve is defined by the equation y² ≡ x³ + α·x + β (mod p).

corelib/src/ecdsa.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
//! * y = 0x5668060aa49730b7be4801df46ec62de53ecd11abe43a32873000c36e8dc1f
1515

1616
use crate::ec::{EcPoint, EcPointTrait, EcStateTrait};
17-
use crate::{ec, math};
1817
#[allow(unused_imports)]
1918
use crate::option::OptionTrait;
2019
#[allow(unused_imports)]
2120
use crate::traits::{Into, TryInto};
2221
#[allow(unused_imports)]
2322
use crate::zeroable::IsZeroResult;
23+
use crate::{ec, math};
2424

2525
/// Verifies an ECDSA signature against a message hash and public key.
2626
///

corelib/src/integer.cairo

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,14 @@
6565
//! * [`TryInto`] for potentially fallible conversions
6666
//! * [`Into`] for infallible conversions to wider types
6767

68+
use crate::RangeCheck;
6869
#[allow(unused_imports)]
6970
use crate::array::{ArrayTrait, SpanTrait};
70-
#[allow(unused_imports)]
71-
use crate::zeroable::{IsZeroResult, NonZeroIntoImpl, Zeroable};
7271
use crate::option::OptionTrait;
7372
use crate::result::ResultTrait;
7473
use crate::traits::{BitAnd, BitNot, BitOr, BitXor, Default, Felt252DictValue, Into, TryInto};
75-
use crate::RangeCheck;
74+
#[allow(unused_imports)]
75+
use crate::zeroable::{IsZeroResult, NonZeroIntoImpl, Zeroable};
7676

7777
// TODO(spapini): Add method for const creation from Integer.
7878
pub trait NumericLiteral<T>;

corelib/src/internal/bounded_int.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
use crate::integer::{downcast, upcast};
21
use crate::RangeCheck;
2+
use crate::integer::{downcast, upcast};
33

44
pub(crate) extern type BoundedInt<const MIN: felt252, const MAX: felt252>;
55

corelib/src/math.cairo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
//!
33
//! Provides extended GCD, modular inverse, and modular arithmetic operations.
44

5-
use crate::integer::{U128MulGuarantee, u256_wide_mul, u512_safe_div_rem_by_u256};
65
use crate::RangeCheck;
6+
use crate::integer::{U128MulGuarantee, u256_wide_mul, u512_safe_div_rem_by_u256};
77
#[allow(unused_imports)]
88
use crate::option::OptionTrait;
99
#[allow(unused_imports)]

corelib/src/prelude/v2023_01.cairo

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ pub use starknet::storage::{
22
StorageMapReadAccess, StorageMapWriteAccess, StoragePointerReadAccess,
33
StoragePointerWriteAccess,
44
};
5-
pub use crate::ops::Deref;
65
use crate::array::{Array, ArrayTrait, Span, SpanTrait, ToSpanTrait};
76
use crate::box::{Box, BoxTrait};
87
use crate::byte_array::{ByteArray, ByteArrayIndexView, ByteArrayStringLiteral, ByteArrayTrait};
@@ -23,7 +22,12 @@ use crate::integer::{
2322
U64IntoFelt252, U8IntoFelt252, i128, i16, i32, i64, i8, u128, u128_is_zero, u16, u256, u32, u64,
2423
u8,
2524
};
25+
#[feature("corelib-internal-use")]
26+
#[deprecated(feature: "corelib-internal-use", note: "Use `core::num::traits::Sqrt` instead")]
27+
use crate::integer::{u128_sqrt, u256_sqrt};
28+
use crate::iter::{FromIterator, IntoIterator, Iterator};
2629
use crate::nullable::{Nullable, NullableTrait, match_nullable, null, nullable_from_box};
30+
pub use crate::ops::Deref;
2731
use crate::option::Option::{None, Some};
2832
use crate::option::{Option, OptionTrait};
2933
use crate::panics::{Panic, PanicResult, panic};
@@ -32,32 +36,11 @@ use crate::poseidon::Poseidon;
3236
use crate::result::Result::{Err, Ok};
3337
use crate::result::{Result, ResultTrait};
3438
use crate::serde::Serde;
35-
use crate::string::StringLiteral;
36-
use crate::traits::{
37-
Add, BitAnd, BitNot, BitOr, BitXor, Copy, Default, Destruct, Div, DivRem, Drop,
38-
Felt252DictValue, Into, Mul, Neg, Not, PanicDestruct, PartialEq, PartialOrd, Rem, Sub, TryInto,
39-
TupleSize0Copy, TupleSize0Drop,
40-
};
41-
use crate::iter::{FromIterator, IntoIterator, Iterator};
42-
use crate::zeroable::{NonZero, Zeroable};
43-
use crate::{
44-
BoolBitAnd, BoolBitOr, BoolBitXor, BoolFelt252DictValue, BoolIntoFelt252, BoolNot,
45-
BoolPartialEq, BoolSerde, Felt252Add, Felt252AddEq, Felt252Default, Felt252Felt252DictValue,
46-
Felt252Mul, Felt252MulEq, Felt252Neg, Felt252PartialEq, Felt252Serde, Felt252Sub, Felt252SubEq,
47-
Felt252TryIntoNonZero, RangeCheck, SegmentArena, array, assert, bool, bool_and_impl,
48-
bool_not_impl, bool_or_impl, bool_to_felt252, bool_xor_impl, box, byte_array, bytes_31, clone,
49-
cmp, debug, dict, drop, dup, ec, ecdsa, felt252, felt252_add, felt252_const, felt252_div,
50-
felt252_is_zero, felt252_mul, felt252_sub, gas, hash, integer, internal, keccak, math, never,
51-
nullable, option, panic_with_felt252, panics, pedersen, poseidon, result, serde, string,
52-
testing, to_byte_array, traits, usize, zeroable,
53-
};
54-
#[feature("corelib-internal-use")]
55-
use crate::starknet::System;
5639
#[feature("corelib-internal-use")]
5740
use crate::starknet;
5841
#[feature("corelib-internal-use")]
59-
#[deprecated(feature: "corelib-internal-use", note: "Use `core::num::traits::Sqrt` instead")]
60-
use crate::integer::{u128_sqrt, u256_sqrt};
42+
use crate::starknet::System;
43+
use crate::string::StringLiteral;
6144
#[cfg(test)]
6245
use crate::test;
6346
#[deprecated(
@@ -85,5 +68,22 @@ pub use crate::traits::RemEq;
8568
)]
8669
#[feature("deprecated-op-assign-traits")]
8770
pub use crate::traits::SubEq;
71+
use crate::traits::{
72+
Add, BitAnd, BitNot, BitOr, BitXor, Copy, Default, Destruct, Div, DivRem, Drop,
73+
Felt252DictValue, Into, Mul, Neg, Not, PanicDestruct, PartialEq, PartialOrd, Rem, Sub, TryInto,
74+
TupleSize0Copy, TupleSize0Drop,
75+
};
8876
#[feature("deprecated-index-traits")]
8977
use crate::traits::{Index, IndexView};
78+
use crate::zeroable::{NonZero, Zeroable};
79+
use crate::{
80+
BoolBitAnd, BoolBitOr, BoolBitXor, BoolFelt252DictValue, BoolIntoFelt252, BoolNot,
81+
BoolPartialEq, BoolSerde, Felt252Add, Felt252AddEq, Felt252Default, Felt252Felt252DictValue,
82+
Felt252Mul, Felt252MulEq, Felt252Neg, Felt252PartialEq, Felt252Serde, Felt252Sub, Felt252SubEq,
83+
Felt252TryIntoNonZero, RangeCheck, SegmentArena, array, assert, bool, bool_and_impl,
84+
bool_not_impl, bool_or_impl, bool_to_felt252, bool_xor_impl, box, byte_array, bytes_31, clone,
85+
cmp, debug, dict, drop, dup, ec, ecdsa, felt252, felt252_add, felt252_const, felt252_div,
86+
felt252_is_zero, felt252_mul, felt252_sub, gas, hash, integer, internal, keccak, math, never,
87+
nullable, option, panic_with_felt252, panics, pedersen, poseidon, result, serde, string,
88+
testing, to_byte_array, traits, usize, zeroable,
89+
};

0 commit comments

Comments
 (0)