Removed too eager solver runners, preventing wrong type assumptions. (#7553)

Author: orizi

crates/cairo-lang-semantic/src/expr/compute.rs

@@ -1954,9 +1954,11 @@ fn compute_expr_indexed_semantic(
     let expr = compute_expr_semantic(ctx, &syntax.expr(syntax_db));
     let index_expr_syntax = &syntax.index_expr(syntax_db);
     let index_expr = compute_expr_semantic(ctx, index_expr_syntax);
-    // Make sure the maximal amount of types is known when trying to access. Ignoring the returned
-    // value, as any errors will be reported later.
-    ctx.resolver.inference().solve().ok();
+    if !ctx.reduce_ty(expr.ty()).is_var_free(ctx.db) {
+        // Make sure the maximal amount of types is known when trying to access. Ignoring the
+        // returned value, as any errors will be reported later.
+        ctx.resolver.inference().solve().ok();
+    }
     let info = ctx.db.core_info();
     let candidate_traits = [info.index_trt, info.index_view_trt];
     let (function_id, _, fixed_expr, mutability) = compute_method_function_call_data(
@@ -2964,8 +2966,13 @@ fn method_call_expr(
     };
     let func_name = segment.identifier(syntax_db);
     let generic_args_syntax = segment.generic_args(syntax_db);
-    // Save some work. ignore the result. The error, if any, will be reported later.
-    ctx.resolver.inference().solve().ok();
+
+    if !ctx.reduce_ty(lexpr.ty()).is_var_free(ctx.db) {
+        // Run solver to get as much info on the type as possible.
+        // Ignore the result of the `solve()` call - the error, if any, will be
+        // reported later.
+        ctx.resolver.inference().solve().ok();
+    }
 
     let mut candidate_traits = traits_in_context(ctx)?;
 
@@ -3168,11 +3175,14 @@ fn get_enriched_type_member_access(
     stable_ptr: ast::ExprPtr,
     accessed_member_name: &str,
 ) -> Maybe<Option<EnrichedTypeMemberAccess>> {
-    // Run solver to get as much info on the type as possible.
-    // Ignore the result of the `solve()` call - the error, if any, will be
-    // reported later.
-    ctx.resolver.inference().solve().ok();
-    let ty = ctx.reduce_ty(expr.ty());
+    let mut ty = ctx.reduce_ty(expr.ty());
+    if !ty.is_var_free(ctx.db) {
+        // Run solver to get as much info on the type as possible.
+        // Ignore the result of the `solve()` call - the error, if any, will be
+        // reported later.
+        ctx.resolver.inference().solve().ok();
+        ty = ctx.reduce_ty(ty);
+    }
     let base_var = match &expr.expr {
         Expr::Var(expr_var) => Some(expr_var.var),
         Expr::MemberAccess(ExprMemberAccess { member_path: Some(member_path), .. }) => {

tests/bug_samples/issue7544.cairo

@@ -0,0 +1,12 @@
+use core::circuit::u384;
+
+pub fn foo(a: u384, b: u384) -> u384 {
+    a
+}
+
+#[test]
+fn test_into_() {
+    let b = 1_u256.into();
+    let a = 0_u256.into();
+    let _r = foo(a, b);
+}

tests/bug_samples/lib.cairo

@@ -62,6 +62,7 @@ mod issue7095;
 mod issue7155;
 mod issue7233;
 mod issue7234;
+mod issue7544;
 mod loop_break_in_match;
 mod loop_only_change;
 mod partial_param_local;