apollo_storage: remove stale allow(dead_code) (#14375)

Four `#[allow(dead_code)]` annotations on table-type methods were stale; the
methods all have production (non-test) callers, so the dead_code lint never
fires for them:

- `DbWriter::create_common_prefix_table` (dup_sort_tables.rs): called in
  `lib.rs` when opening storage (contract_storage, events, nonces,
  compiled_class_hash tables).
- `append_greater_sub_key` (dup_sort_tables.rs): called in `body/mod.rs:545`
  (events) and `state/mod.rs:875,920` (nonces, storage).
- `Table::append` trait method (table_types/mod.rs) and its `SimpleTable`
  impl (simple_table.rs): called in `header.rs:331` and `body/mod.rs:508`.

Removed only the annotations; no behavior change. Verified that the lib build
and the test build both compile with no dead_code warnings.

Co-authored-by: Claude <noreply@anthropic.com>

Author: asaf-sw

crates/apollo_storage/src/db/table_types/dup_sort_tables.rs

@@ -101,7 +101,6 @@ where
 }
 
 impl DbWriter {
-    #[allow(dead_code)]
     pub(crate) fn create_common_prefix_table<
         MainKey: KeyTrait + Debug,
         SubKey: KeyTrait + Debug,
@@ -345,7 +344,6 @@ impl<'env, K: KeyTrait + Debug, V: ValueSerde + Debug, T: DupSortTableType + Dup
     // The sub-key is equal to the last sub-key of the given main-key.
     // NOTICE: if this returns an error, the transaction should not be committed. Doing so can cause
     // a corrupt database.
-    #[allow(dead_code)]
     pub(crate) fn append_greater_sub_key(
         &'env self,
         txn: &DbTransaction<'env, RW>,

crates/apollo_storage/src/db/table_types/mod.rs

@@ -56,7 +56,6 @@ pub(crate) trait Table<'env> {
 
     // Append a key value pair to the end of the table. The key must be bigger than or equal to
     // the last key in the table; otherwise, an error will be returned.
-    #[allow(dead_code)]
     fn append(
         &'env self,
         txn: &DbTransaction<'env, RW>,

crates/apollo_storage/src/db/table_types/simple_table.rs

@@ -112,7 +112,6 @@ impl<'env, K: KeyTrait + Debug, V: ValueSerde + Debug> Table<'env>
         Ok(())
     }
 
-    #[allow(dead_code)]
     fn append(
         &'env self,
         txn: &DbTransaction<'env, RW>,