starknet_os: import random EC point logic (#14195)

Author: dorimedini-starkware

crates/starknet_os/src/hint_processor/aggregator_hint_processor.rs

@@ -3,7 +3,7 @@ use std::boxed::Box;
 use std::path::PathBuf;
 
 use cairo_lang_casm::hints::{CoreHint, CoreHintBase, Hint as Cairo1Hint, StarknetHint};
-use cairo_lang_runner::casm_run::{cell_ref_to_relocatable, execute_core_hint_base};
+use cairo_lang_runner::casm_run::execute_core_hint_base;
 use cairo_vm::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::{
     BuiltinHintProcessor,
     HintProcessorData as Cairo0Hint,
@@ -14,7 +14,6 @@ use cairo_vm::types::program::Program;
 use cairo_vm::vm::errors::hint_errors::HintError as VmHintError;
 use cairo_vm::vm::runners::cairo_runner::ResourceTracker;
 use cairo_vm::vm::vm_core::VirtualMachine;
-use rand::RngExt;
 use serde::Deserialize;
 use starknet_types_core::felt::Felt;
 use tracing::level_filters::LevelFilter;

crates/starknet_os/src/hint_processor/common_hint_processor.rs

@@ -105,25 +105,7 @@ macro_rules! impl_common_hint_processor_logic {
                 // Override the [CoreHint::RandomEcPoint] implementation to make the output
                 // deterministic (using seeded randomness).
                 Cairo1Hint::Core(CoreHintBase::Core(CoreHint::RandomEcPoint { x, y })) => {
-                    // TODO(Dori): use the random_ec_point function from the compiler repo when
-                    //   available, instead of inlining the implementation.
-                    /// The Beta value of the Starkware elliptic curve.
-                    pub const BETA: Felt = Felt::from_hex_unchecked(
-                        "0x6f21413efbe40de150e596d72f7a8c5609ad26c15c915c1f4cdfcb99cee9e89",
-                    );
-                    // Use the seeded randomness.
-                    let rng = self.get_rng();
-                    let (random_x, random_y) = loop {
-                        // Randomizing 31 bytes to make sure it is in range.
-                        let x_bytes: [u8; 31] = rng.random();
-                        let random_x = Felt::from_bytes_be_slice(&x_bytes);
-                        let random_y_squared = random_x * random_x * random_x + random_x + BETA;
-                        if let Some(random_y) = random_y_squared.sqrt() {
-                            break (random_x, random_y);
-                        }
-                    };
-                    cairo_lang_runner::insert_value_to_cellref!(vm, x, random_x)?;
-                    cairo_lang_runner::insert_value_to_cellref!(vm, y, random_y)?;
+                    cairo_lang_runner::casm_run::random_ec_point(vm, x, y, self.get_rng())?;
                     Ok(HintExtension::default())
                 }
                 Cairo1Hint::Core(hint) => {

crates/starknet_os/src/hint_processor/snos_hint_processor.rs

@@ -9,7 +9,7 @@ use blockifier::state::state_api::StateReader;
 #[cfg(any(feature = "testing", test))]
 use blockifier::test_utils::dict_state_reader::DictStateReader;
 use cairo_lang_casm::hints::{CoreHint, CoreHintBase, Hint as Cairo1Hint, StarknetHint};
-use cairo_lang_runner::casm_run::{cell_ref_to_relocatable, execute_core_hint_base};
+use cairo_lang_runner::casm_run::execute_core_hint_base;
 use cairo_lang_starknet_classes::casm_contract_class::CasmContractClass;
 use cairo_vm::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::{
     BuiltinHintProcessor,
@@ -22,7 +22,7 @@ use cairo_vm::types::relocatable::Relocatable;
 use cairo_vm::vm::errors::hint_errors::HintError as VmHintError;
 use cairo_vm::vm::runners::cairo_runner::ResourceTracker;
 use cairo_vm::vm::vm_core::VirtualMachine;
-use rand::{RngExt, SeedableRng};
+use rand::SeedableRng;
 use starknet_api::core::{ClassHash, CompiledClassHash};
 use starknet_api::deprecated_contract_class::ContractClass;
 use starknet_types_core::felt::Felt;