Commit c98ef03
authored
chore: simplify — trim narrative comments, make eslint --cache pay off in CI (#23)
Quality
- functions/api/hello.js: drop 3-line preamble; the 405 guard is self-evident.
- functions/api/visits.js: collapse 4-line block to 2 lines, keeping the
non-obvious WHY (GET overloaded as increment+read).
- .github/workflows/cd.yml: tighten id-token comment to one line.
- .github/dependabot.yml: collapse 3-line narration into one line that
states the contract.
- .github/CODEOWNERS: drop 6-line preamble; the per-section comments below
already convey scope.
Efficiency
- .github/workflows/ci.yml: add actions/cache@v4 step for .eslintcache.
Without it, `eslint --cache` writes to a file that gets discarded every
CI run, giving zero speedup beyond local dev. Cache key includes lockfile,
config, and source hash so invalidation tracks real changes.
Verification
- npm test: 19/19
- npm run lint: clean1 parent b656eac commit c98ef03
6 files changed
Lines changed: 17 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 1 | + | |
| 2 | + | |
7 | 3 | | |
8 | 4 | | |
9 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
| 9 | + | |
12 | 10 | | |
13 | 11 | | |
14 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
| 20 | + | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
51 | 62 | | |
52 | 63 | | |
53 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 11 | | |
15 | 12 | | |
16 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 24 | + | |
| 25 | + | |
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
| |||
0 commit comments