Skip to content

Commit 8efae13

Browse files
authored
Revert dot marker styling changes (#5801)
* Move marker css into styles Removes vjs-marker-dot styling, using existing vjs-marker class instead * Revert dot marker changes
1 parent 6ed66f3 commit 8efae13

File tree

3 files changed

+14
-30
lines changed

3 files changed

+14
-30
lines changed

ui/v2.5/src/components/ScenePlayer/markers.css

Lines changed: 0 additions & 27 deletions
This file was deleted.

ui/v2.5/src/components/ScenePlayer/markers.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import videojs, { VideoJsPlayer } from "video.js";
2-
import "./markers.css";
32
import CryptoJS from "crypto-js";
43

54
export interface IMarker {
@@ -67,14 +66,16 @@ class MarkersPlugin extends videojs.getPlugin("plugin") {
6766
dot?: HTMLDivElement;
6867
range?: HTMLDivElement;
6968
} = {};
70-
const seekBar = this.player.el().querySelector(".vjs-progress-control");
69+
const seekBar = this.player.el().querySelector(".vjs-progress-holder");
7170

7271
markerSet.dot = videojs.dom.createEl("div") as HTMLDivElement;
73-
markerSet.dot.className = "vjs-marker-dot";
72+
markerSet.dot.className = "vjs-marker";
7473
if (duration) {
74+
// marker is 6px wide - adjust by 3px to align to center not left side
7575
markerSet.dot.style.left = `calc(${
7676
(marker.seconds / duration) * 100
7777
}% - 3px)`;
78+
markerSet.dot.style.visibility = "visible";
7879
}
7980

8081
// Add event listeners to dot

ui/v2.5/src/components/ScenePlayer/styles.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,16 @@ $sceneTabWidth: 450px;
266266
}
267267
}
268268

269+
.vjs-marker-range {
270+
background-color: rgba(255, 255, 255, 0.4);
271+
border-radius: 2px;
272+
box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
273+
height: 8px;
274+
position: absolute;
275+
transform: translateY(-28px);
276+
transition: none;
277+
}
278+
269279
.vjs-marker-tooltip {
270280
background-color: #fff;
271281
background-color: rgba(255, 255, 255, 0.8);

0 commit comments

Comments
 (0)