Skip to content

Conversation

@jhhazelaar
Copy link
Contributor

Fixes #8430

@jasonvarga jasonvarga changed the title Enabled antlers parsing for values in Blade template [4.x] Enabled antlers parsing for values in Blade template Jul 11, 2023
@jhhazelaar
Copy link
Contributor Author

@jasonvarga don't want to rush you with the great work you are doing. But... do you have any idea of when this fix will be released? A client of ours is depending on this and we don't want to install a dev branch in production.

@jacksleight
Copy link
Contributor

jacksleight commented Jul 25, 2023

@jhhazelaar FYI you can currently work around this with the antlers modifier:

{{ Statamic::modify($page->content)->antlers() }}

In fact I think this was one reason that modifier was added in the first place.

@jasonvarga
Copy link
Member

The changes you are proposing in this PR potentially affect an extremely wide range of areas, so I want to take care with it.

You can use it before it's merged with a Composer patch. https://rias.be/blog/using-composer-patches

@jhhazelaar
Copy link
Contributor Author

@jacksleight thanks for the workaround. This works!

I still think this is a workaround. If the modifier was added to do this for a field, then we need to remove the option in the control panel. So a developer decided where antlers variables can be used in a field and nog a admin in the control panel. But that's only my thoughts.

@jasonvarga of course this is a small change with big impact. Workaround works so the client is happy.

@jasonvarga
Copy link
Member

jasonvarga commented Nov 10, 2023

Thank you for this PR, but it needs some more thought. We'll try to tackle this from a different angle. Even though all tests pass and it seems like a small change, It just doesn't quite feel right because of the large effect it may have.

Please stick with the workaround for now.

@jasonvarga jasonvarga closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Antlers parsing in field doesn't work with blade templates

3 participants