Fix phpstan errors

Author: sten

phpstan.neon.dist

@@ -10,4 +10,9 @@ parameters:
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true
+    ignoreErrors:
+        - identifier: trait.unused
+        -
+            identifier: larastan.noEnvCallsOutsideOfConfig
+            path: src/FilamentFlexibleContentBlocksServiceProvider.php
 

src/Exceptions/LinkableModelNotFoundException.php

@@ -6,7 +6,7 @@
 
 class LinkableModelNotFoundException extends \Exception
 {
-    private ?Model $record;
+    private ?Model $record = null;
 
     public static function create(string $message)
     {

src/Filament/Form/Fields/Blocks/Type/AbstractType.php

@@ -98,10 +98,7 @@ protected function setUp(): void
             $keyName = $query->getModel()->getKeyName();
 
             if ($this->hasOptionLabelFromRecordUsingCallback()) {
-                $locale = null;
-                if (method_exists($component->getLivewire(), 'getActiveFormsLocale')) {
-                    $locale = $component->getLivewire()->getActiveFormsLocale();
-                }
+                $locale = $component->getLivewire()->getActiveFormsLocale();
 
                 return $query
                     ->get()
@@ -136,10 +133,7 @@ protected function setUp(): void
             $keyName = $query->getModel()->getKeyName();
 
             if ($this->hasOptionLabelFromRecordUsingCallback()) {
-                $locale = null;
-                if (method_exists($component->getLivewire(), 'getActiveFormsLocale')) {
-                    $locale = $component->getLivewire()->getActiveFormsLocale();
-                }
+                $locale = $component->getLivewire()->getActiveFormsLocale();
 
                 return $query
                     ->get()
@@ -172,10 +166,7 @@ protected function setUp(): void
             }
 
             if ($this->hasOptionLabelFromRecordUsingCallback()) {
-                $locale = null;
-                if (method_exists($component->getLivewire(), 'getActiveFormsLocale')) {
-                    $locale = $component->getLivewire()->getActiveFormsLocale();
-                }
+                $locale = $component->getLivewire()->getActiveFormsLocale();
 
                 return $this->getOptionLabelFromRecord($record, $locale);
             }

src/Filament/Form/Fields/Flexible/FlexibleSelectField.php

@@ -53,7 +53,7 @@ protected function getCachedOptions(): array
 
     protected function hasOnlyOneOption(): bool
     {
-        return is_array($this->getCachedOptions()) && count($this->getCachedOptions()) === 1;
+        return count($this->getCachedOptions()) === 1;
     }
 
     public function isHidden(): bool

src/Filament/Form/Fields/HeroImageField.php

@@ -15,7 +15,7 @@ public static function create(bool $translatable = false): SpatieMediaLibraryFil
         return static::createImageField(static::FIELD, $translatable)
             ->label(trans('filament-flexible-content-blocks::filament-flexible-content-blocks.form_component.hero_image_lbl'))
             ->collection(function (Model $record) {
-                /** @var HasHeroImageAttributes $record */
+                /** @var Model&HasHeroImageAttributes $record */
                 return $record->getHeroImageCollection();
             })
             ->conversion('thumbnail');

src/Filament/Form/Fields/OverviewImageField.php

@@ -15,7 +15,7 @@ public static function create(bool $translatable = false): SpatieMediaLibraryFil
         return static::createImageField(static::FIELD, $translatable)
             ->label(trans('filament-flexible-content-blocks::filament-flexible-content-blocks.form_component.overview_image_lbl'))
             ->collection(function (Model $record) {
-                /** @var HasOverviewAttributes $record */
+                /** @var Model&HasOverviewAttributes $record */
                 return $record->getOverviewImageCollection();
             })
             ->conversion('thumbnail');

src/Filament/Form/Fields/SEOImageField.php

@@ -15,7 +15,7 @@ public static function create(bool $translatable = false): SpatieMediaLibraryFil
         return static::createImageField('seo_image', $translatable)
             ->label(trans('filament-flexible-content-blocks::filament-flexible-content-blocks.form_component.seo_image_lbl'))
             ->collection(function (Model $record) {
-                /** @var HasSEOAttributes $record */
+                /** @var Model&HasSEOAttributes $record */
                 return $record->getSEOImageCollection();
             })
             ->conversion('thumbnail');

src/Filament/Form/Fields/SlugField.php

@@ -45,7 +45,7 @@ public static function create(bool $disabled = true): static
                 }
 
                 if (isset($record->translatable) && in_array(static::FIELD, $record->translatable)) {
-                    if (method_exists($livewire, 'getActiveFormsLocale') && method_exists($record, 'getTranslation')) {
+                    if (method_exists($record, 'getTranslation')) {
                         $locale = $livewire->getActiveFormsLocale();
 
                         $noSlug = empty($record->getTranslation(static::FIELD, $locale, false));
@@ -69,7 +69,7 @@ protected static function getUrlWithReplacementSlug(Page $livewire): string
         /* @var Linkable $link */
         $link = new $linkModel;
 
-        if (method_exists($livewire, 'getActiveFormsLocale') && method_exists($link, 'setTranslation')) {
+        if (method_exists($link, 'setTranslation')) {
             $locale = $livewire->getActiveFormsLocale();
             $link->setTranslation('slug', $locale, static::URL_REPLACEMENT_SLUG);
         } else {

src/Filament/Table/Actions/PublishAction.php

@@ -22,9 +22,9 @@ public function setUp(): void
             try {
                 /** @var Model&HasPageAttributes $page */
                 $page = $this->getRecord();
-                if (method_exists($page, 'isPublished') && ! $page->isPublished()) {
+                if (! $page->isPublished()) {
                     $page->setAttribute('publishing_begins_at', Carbon::now());
-                    if (method_exists($page, 'wasUnpublished') && $page->wasUnpublished()) {
+                    if ($page->wasUnpublished()) {
                         $page->setAttribute('publishing_ends_at', null);
                     }
                     $page->save();
@@ -56,18 +56,18 @@ public function setUp(): void
             return response();
         });
         $this->label(function () {
-            /* @var Model|HasPageAttributes $page */
+            /** @var Model&HasPageAttributes $page */
             $page = $this->getRecord();
-            if (method_exists($page, 'isPublished') && $page->isPublished()) {
+            if ($page->isPublished()) {
                 return trans('filament-flexible-content-blocks::filament-flexible-content-blocks.table_action.publish.unpublish_lbl');
             } else {
                 return trans('filament-flexible-content-blocks::filament-flexible-content-blocks.table_action.publish.publish_lbl');
             }
         });
         $this->icon(function () {
-            /** @var Model|HasPageAttributes $page */
+            /** @var Model&HasPageAttributes $page */
             $page = $this->getRecord();
-            if (method_exists($page, 'isPublished') && $page->isPublished()) {
+            if ($page->isPublished()) {
                 return 'heroicon-o-eye-slash';
             } else {
                 return 'heroicon-o-eye';