Handle startup warnings (#435)

* Fix access mesage format

* Add a default value for POSTGRES_INSTANCE locally

* PostgreSQLDialect does not need to be specified explicitly

* Fix access log misconfiguration

* Suppress unnecessary warnings

Author: mmwinther

klass-api/src/main/resources/application-postgres-local.properties

@@ -1,19 +1,17 @@
 # custom properties used when "postgres-local" Profile is used
-spring.datasource.url=jdbc:postgresql://${POSTGRES_INSTANCE}:5432/klass
+spring.datasource.url=jdbc:postgresql://${POSTGRES_INSTANCE:localhost}:5432/klass
 spring.datasource.username=klass
 spring.datasource.password=${POSTGRES_PASSWORD}
 spring.datasource.driverclassName=org.postgresql.Driver
 spring.jpa.hibernate.ddl-auto=none
 spring.datasource.hikari.connection-test-query=SELECT 1
 spring.datasource.hikari.validation-timeout=3000
 spring.jpa.properties.hibernate.format_sql=true
-spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.PostgreSQLDialect
-
 # Flyway
 spring.flyway.enabled=true
-spring.flyway.url=jdbc:postgresql://${POSTGRES_INSTANCE}:5432/klass
+spring.flyway.url=jdbc:postgresql://${POSTGRES_INSTANCE:localhost}:5432/klass
 spring.flyway.password=${POSTGRES_PASSWORD}
 spring.flyway.user=klass
 spring.flyway.locations=classpath:db/migration
 # This is for first time running on a database with data, but no flyway schema history table
-spring.flyway.baseline-on-migrate=true
+spring.flyway.baseline-on-migrate=true

klass-api/src/main/resources/application-postgres.properties

@@ -5,7 +5,6 @@ spring.datasource.hikari.connection-test-query=SELECT 1
 spring.datasource.hikari.data-source-properties.tcpKeepAlive=true
 spring.datasource.hikari.connection-timeout=60000
 spring.datasource.hikari.maximum-pool-size=25
-spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.PostgreSQLDialect
 # Flyway
 spring.flyway.enabled=true
 spring.flyway.url=${NAIS_DATABASE_KLASS_KLASS_JDBC_URL}

klass-api/src/main/resources/application.properties

@@ -11,8 +11,6 @@ info.build.version=@project.version@
 # Profiles for development
 #   small-import        = imports a small number of classifications from legacy system, useful during development
 #   mock-mailserver     = outgoing emails are only logged
-#   h2                  = use h2 database (stored on your filesystem)
-#   h2-inmemory         = use h2 database but keep everything in memory only.(tests must use h2-inmemory)
 #   embedded-postgres   = use embedded postgresql for testing with postgres engine
 #   postgres-local      = postgresql database (local container)
 #----------------------
@@ -54,7 +52,11 @@ spring.main.allow-bean-definition-overriding=true
 spring.jackson.time-zone=UTC
 # Required when running behind a load balancer or reverse proxy server
 server.forward-headers-strategy=NATIVE
+# Prevent unnecessary logs
+logging.level.org.springdoc.core.events.SpringDocAppInitializer=ERROR
 springdoc.api-docs.enabled=true
 springdoc.swagger-ui.enabled=true
 # Prevent runtime warnings about missing jars
 server.tomcat.additional-tld-skip-patterns=*.jar
+# Several queries are dependent on this functionality
+spring.jpa.open-in-view=true

klass-api/src/main/resources/logback-access.xml

@@ -12,20 +12,20 @@
             <OnMatch>DENY</OnMatch>
         </filter>
         <encoder class="net.logstash.logback.encoder.LogstashAccessEncoder">
+            <messagePattern>%requestURL - %statusCode - %i{User-Agent}</messagePattern>
             <fieldNames>
-                <messagePattern>%requestURL - %statusCode - %i{User-Agent}</messagePattern>
                 <requestHeaders>request_headers</requestHeaders>
                 <responseHeaders>response_headers</responseHeaders>
             </fieldNames>
-            <pattern>
+            <provider class="net.logstash.logback.composite.loggingevent.LoggingEventPatternJsonProvider">
                 <pattern>
                     {
                     "context": "klass-api",
                     "logger_name": "tomcat.access",
                     "level": "INFO"
                     }
                 </pattern>
-            </pattern>
+            </provider>
         </encoder>
     </appender>
     <appender-ref ref="accessJsonConsoleAppender"/>