Skip to content

Commit 1c2d8e8

Browse files
Renamed JSON field feilkode -> severity (#1047)
1 parent d971721 commit 1c2d8e8

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

web-frontend/src/components/ReportView.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe("ReportView", () => {
1111
appReleaseVersion={appReleaseVersionInTest}
1212
fileReport={{
1313
...fileReportInTest,
14-
feilkode: KostraSeverity.OK,
14+
severity: KostraSeverity.OK,
1515
feil: []
1616
}}
1717
/>)

web-frontend/src/features/report/ErrorLevel.spec.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,14 @@ describe("ErrorLevel", () => {
4949
render(<ErrorLevel level={KostraSeverity.FATAL}/>)
5050
expect(screen.getByText("Kritisk").classList.contains("text-danger")).toBeTruthy()
5151
})
52+
53+
it("unknown error, expect text 'Ukjent'", () => {
54+
render(<ErrorLevel level={"UNKNOWN" as any}/>)
55+
expect(screen.queryByText("Ukjent")).toBeInTheDocument()
56+
})
57+
it("unknown error, expect cssClass 'text-muted'", () => {
58+
render(<ErrorLevel level={"UNKNOWN" as any}/>)
59+
expect(screen.getByText("Ukjent").classList.contains("text-muted")).toBeTruthy()
60+
})
5261
})
5362
})

web-frontend/src/features/report/ReportSummary.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const ReportSummary = ({appReleaseVersion, fileReport}: {
3131
Organisasjonsnummer: {fileReport.innparametere.orgnrForetak}
3232
</li>}
3333
<li className="list-group-item">
34-
Høyeste alvorlighetsgrad: <ErrorLevel level={fileReport.feilkode}/>
34+
Høyeste alvorlighetsgrad: <ErrorLevel level={fileReport.severity}/>
3535
</li>
3636
<li className="list-group-item">
3737
Antall kontroller utført: {fileReport.antallKontroller}

web-frontend/src/kostratypes/fileReportVm.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Nullable from "./nullable"
66
interface FileReportVm {
77
readonly innparametere: NonNullable<KostraFormVm>
88
readonly antallKontroller: NonNullable<number>
9-
readonly feilkode: NonNullable<KostraSeverity>
9+
readonly severity: NonNullable<KostraSeverity>
1010
readonly feil: Nullable<FileReportEntryVm[]>
1111
}
1212

web-frontend/src/specData.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,6 @@ export const fileReportEntryInTestWithAllPropsSet: FileReportEntryVm = {
5454
export const fileReportInTest: FileReportVm = {
5555
innparametere: kostraFormInTest,
5656
antallKontroller: 42,
57-
feilkode: KostraSeverity.WARNING,
57+
severity: KostraSeverity.WARNING,
5858
feil: [fileReportEntryInTestWithAllPropsSet]
5959
}

0 commit comments

Comments
 (0)