Skip to content

Commit 982c12d

Browse files
authored
use correct span tags (#184)
1 parent e180c8e commit 982c12d

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

src/main/java/no/ssb/dlp/pseudo/service/pseudo/PseudoController.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
import io.micronaut.scheduling.TaskExecutors;
1010
import io.micronaut.scheduling.annotation.ExecuteOn;
1111
import io.micronaut.security.annotation.Secured;
12-
import io.micronaut.tracing.annotation.NewSpan;
13-
import io.micronaut.tracing.annotation.SpanTag;
12+
import io.opentelemetry.instrumentation.annotations.AddingSpanAttributes;
13+
import io.opentelemetry.instrumentation.annotations.SpanAttribute;
14+
import io.opentelemetry.instrumentation.annotations.WithSpan;
1415
import io.reactivex.Flowable;
1516
import io.opentelemetry.api.trace.Span;
1617
import io.swagger.v3.oas.annotations.Operation;
@@ -30,14 +31,8 @@
3031

3132
import org.slf4j.MDC;
3233

33-
import java.io.File;
34-
import java.io.IOException;
35-
import java.io.InputStream;
3634
import java.lang.reflect.InvocationTargetException;
3735
import java.nio.charset.StandardCharsets;
38-
import java.nio.file.Files;
39-
import java.nio.file.Path;
40-
import java.security.Principal;
4136
import java.util.List;
4237

4338
/*
@@ -65,13 +60,14 @@ public class PseudoController {
6560
* @return HTTP response containing a {@link HttpResponse<Flowable>} object.
6661
*/
6762

68-
@NewSpan("pseudonyimze column")
63+
@WithSpan("pseudonyimze column")
64+
@AddingSpanAttributes
6965
@Operation(summary = "Pseudonymize field", description = "Pseudonymize a field.")
7066
@Produces(MediaType.APPLICATION_JSON)
7167
@Post(value = "/pseudonymize/field", consumes = MediaType.APPLICATION_JSON)
7268
@ExecuteOn(TaskExecutors.BLOCKING)
7369
public HttpResponse<Flowable<byte[]>> pseudonymizeField(
74-
@SpanTag("pseudonymize column request") @Schema(implementation = PseudoFieldRequest.class) String request
70+
@SpanAttribute("pseudonymize column request") @Schema(implementation = PseudoFieldRequest.class) String request
7571
) {
7672
PseudoFieldRequest req = Json.toObject(PseudoFieldRequest.class, request);
7773
Span currentSpan = Span.current();

src/main/java/no/ssb/dlp/pseudo/service/pseudo/RecordMapProcessorFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.github.benmanes.caffeine.cache.LoadingCache;
44
import com.google.crypto.tink.Aead;
5-
import io.micronaut.tracing.annotation.ContinueSpan;
5+
import io.opentelemetry.instrumentation.annotations.AddingSpanAttributes;
66
import jakarta.inject.Singleton;
77
import lombok.RequiredArgsConstructor;
88
import lombok.extern.slf4j.Slf4j;
@@ -48,7 +48,7 @@ public class RecordMapProcessorFactory {
4848
private final PseudoSecrets pseudoSecrets;
4949
private final LoadingCache<String, Aead> aeadCache;
5050

51-
@ContinueSpan
51+
@AddingSpanAttributes
5252
public RecordMapProcessor<PseudoMetadataProcessor> newPseudonymizeRecordProcessor(List<PseudoConfig> pseudoConfigs, String correlationId) {
5353
ValueInterceptorChain chain = new ValueInterceptorChain();
5454
PseudoMetadataProcessor metadataProcessor = new PseudoMetadataProcessor(correlationId);
@@ -66,7 +66,7 @@ public RecordMapProcessor<PseudoMetadataProcessor> newPseudonymizeRecordProcesso
6666
return new RecordMapProcessor<>(chain, metadataProcessor);
6767
}
6868

69-
@ContinueSpan
69+
@AddingSpanAttributes
7070
public RecordMapProcessor<PseudoMetadataProcessor> newDepseudonymizeRecordProcessor(List<PseudoConfig> pseudoConfigs, String correlationId) {
7171
ValueInterceptorChain chain = new ValueInterceptorChain();
7272
PseudoMetadataProcessor metadataProcessor = new PseudoMetadataProcessor(correlationId);
@@ -81,7 +81,7 @@ public RecordMapProcessor<PseudoMetadataProcessor> newDepseudonymizeRecordProces
8181
return new RecordMapProcessor<>(chain, metadataProcessor);
8282
}
8383

84-
@ContinueSpan
84+
@AddingSpanAttributes
8585
public RecordMapProcessor<PseudoMetadataProcessor> newRepseudonymizeRecordProcessor(PseudoConfig sourcePseudoConfig,
8686
PseudoConfig targetPseudoConfig, String correlationId) {
8787
final PseudoFuncs fieldDepseudonymizer = newPseudoFuncs(sourcePseudoConfig.getRules(),

0 commit comments

Comments
 (0)