fix: Flip control/ownership primary_influencer_only semantics

jhf · claude · jhf · commit 2160f3163b9f · 2026-02-28T22:56:18.000+01:00
The dbseed had control and ownership backwards:
- Control (singular, hierarchy-forming) should be primary_influencer_only=TRUE
- Ownership (shared, informational) should be primary_influencer_only=FALSE

Swap type codes in demo CSVs to match: hierarchy-forming
relationships are now 'control', shared stakes are now 'ownership'.

Fix stale "50% or more" text in frontend import page — power groups
form based on relationship type, not percentage thresholds.

Fix nondeterministic ORDER BY in test 120 by adding lr.percentage.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/app/public/demo/legal_relationships_demo.csv b/app/public/demo/legal_relationships_demo.csv
@@ -1,6 +1,6 @@
 influencing_tax_ident,influenced_tax_ident,rel_type_code,percentage
-2407020166,2812760140,ownership,60
-2407020166,2602025168,control,100
-397611,397622,ownership,51
-2612760138,2507020167,ownership,75
-2200019,3300598,control,80
+2407020166,2812760140,control,60
+2407020166,2602025168,ownership,100
+397611,397622,control,51
+2612760138,2507020167,control,75
+2200019,3300598,ownership,80
diff --git a/app/public/demo/legal_relationships_with_source_dates_demo.csv b/app/public/demo/legal_relationships_with_source_dates_demo.csv
@@ -1,15 +1,15 @@
 influencing_tax_ident,influenced_tax_ident,rel_type_code,percentage,valid_from,valid_to
-2407020166,2812760140,ownership,40,2023-01-01,2023-12-31
-2407020166,2812760140,ownership,60,2024-01-01,2024-12-31
-2407020166,2812760140,ownership,60,2025-01-01,infinity
-2407020166,2602025168,control,100,2023-01-01,2023-12-31
-2407020166,2602025168,control,100,2024-01-01,2024-12-31
-2407020166,2602025168,control,100,2025-01-01,infinity
-397611,397622,ownership,34,2023-01-01,2023-12-31
-397611,397622,ownership,51,2024-01-01,2024-12-31
-397611,397622,ownership,51,2025-01-01,infinity
-2612760138,2507020167,ownership,75,2024-01-01,2024-12-31
-2612760138,2507020167,ownership,75,2025-01-01,infinity
-2200019,3300598,control,80,2023-01-01,2023-12-31
-2200019,3300598,control,80,2024-01-01,2024-12-31
-2200019,3300598,control,50,2025-01-01,infinity
+2407020166,2812760140,control,40,2023-01-01,2023-12-31
+2407020166,2812760140,control,60,2024-01-01,2024-12-31
+2407020166,2812760140,control,60,2025-01-01,infinity
+2407020166,2602025168,ownership,100,2023-01-01,2023-12-31
+2407020166,2602025168,ownership,100,2024-01-01,2024-12-31
+2407020166,2602025168,ownership,100,2025-01-01,infinity
+397611,397622,control,34,2023-01-01,2023-12-31
+397611,397622,control,51,2024-01-01,2024-12-31
+397611,397622,control,51,2025-01-01,infinity
+2612760138,2507020167,control,75,2024-01-01,2024-12-31
+2612760138,2507020167,control,75,2025-01-01,infinity
+2200019,3300598,ownership,80,2023-01-01,2023-12-31
+2200019,3300598,ownership,80,2024-01-01,2024-12-31
+2200019,3300598,ownership,50,2025-01-01,infinity
diff --git a/app/src/app/import/legal-relationships/page.tsx b/app/src/app/import/legal-relationships/page.tsx
@@ -117,20 +117,22 @@ export default function LegalRelationshipsPage() {
           <AccordionTrigger>What is a Legal Relationship?</AccordionTrigger>
           <AccordionContent>
             <p className="mb-3">
-              A <strong>Legal Relationship</strong> represents an ownership or
-              control link between two Legal Units. When one Legal Unit owns 50%
-              or more of another, they form part of a <strong>Power Group</strong>{" "}
-              (a cluster of entities under common control).
+              A <strong>Legal Relationship</strong> represents a control or
+              ownership link between two Legal Units. Relationship types marked
+              as hierarchy-forming (e.g. control) define{" "}
+              <strong>Power Groups</strong> — clusters of entities under common
+              control. Other types (e.g. ownership) record shared stakes without
+              affecting the hierarchy.
             </p>
           </AccordionContent>
         </AccordionItem>
         <AccordionItem value="Legal Relationships File">
           <AccordionTrigger>What is a Legal Relationships file?</AccordionTrigger>
           <AccordionContent>
             <p className="mb-3">
-              A Legal Relationships file is a CSV file containing ownership links.
-              Each row specifies an influencing Legal Unit (owner), an influenced
-              Legal Unit (owned), and an ownership percentage.
+              A Legal Relationships file is a CSV file containing relationship
+              links. Each row specifies an influencing Legal Unit, an influenced
+              Legal Unit, a relationship type code, and an optional percentage.
             </p>
             <div className="flex flex-col space-y-2 pl-4">
               <a
diff --git a/migrations/20240428000000_generate_table_views_for_batch_api.up.psql b/migrations/20240428000000_generate_table_views_for_batch_api.up.psql
@@ -14,7 +14,7 @@ SET LOCAL client_min_messages TO INFO;
 \copy public.legal_rel_type_system(code, name, description) FROM 'dbseed/legal_rel_type.csv' WITH (FORMAT csv, DELIMITER ',', QUOTE '"', HEADER true);
 
 -- Set primary_influencer_only (not supported by auto-generated _system view)
-UPDATE public.legal_rel_type SET primary_influencer_only = TRUE WHERE code = 'ownership';
-UPDATE public.legal_rel_type SET primary_influencer_only = FALSE WHERE code = 'control';
+UPDATE public.legal_rel_type SET primary_influencer_only = FALSE WHERE code = 'ownership';
+UPDATE public.legal_rel_type SET primary_influencer_only = TRUE WHERE code = 'control';
 
 END;
diff --git a/test/expected/117_power_group_fundamentals.out b/test/expected/117_power_group_fundamentals.out
@@ -53,9 +53,9 @@ WHERE NOT EXISTS (SELECT 1 FROM public.legal_rel_type WHERE code = 'co_ownership
 SELECT code, name, description, primary_influencer_only FROM public.legal_rel_type ORDER BY code;
       code      |      name      |                                   description                                    | primary_influencer_only 
 ----------------+----------------+----------------------------------------------------------------------------------+-------------------------
- control        | Control        | Controlling interest (may differ from ownership via voting rights or agreements) | f
+ control        | Control        | Controlling interest (may differ from ownership via voting rights or agreements) | t
  co_ownership   | Co-ownership   | Shared ownership (multiple co-owners per entity)                                 | f
- ownership      | Ownership      | Direct share ownership percentage                                                | t
+ ownership      | Ownership      | Direct share ownership percentage                                                | f
  parent_company | Parent Company | Parent-subsidiary relationship (structurally 1:1 per subsidiary)                 | t
 (4 rows)
 
diff --git a/test/expected/120_power_group_lifecycle.out b/test/expected/120_power_group_lifecycle.out
@@ -668,7 +668,7 @@ JOIN public.external_ident AS ei_ed ON ei_ed.legal_unit_id = lu_ed.id
 JOIN public.external_ident_type AS eit_ed ON eit_ed.id = ei_ed.type_id AND eit_ed.code = 'tax_ident'
 LEFT JOIN public.power_group AS pg ON pg.id = lr.power_group_id
 WHERE ei_ing.ident LIKE '30000000%'
-ORDER BY ei_ing.ident, ei_ed.ident;
+ORDER BY ei_ing.ident, ei_ed.ident, lr.percentage;
  influencing | influenced | percentage | power_group_ident 
 -------------+------------+------------+-------------------
  300000001   | 300000002  |      80.00 | PG0004
@@ -822,7 +822,7 @@ JOIN public.external_ident_type AS eit_ed ON eit_ed.id = ei_ed.type_id AND eit_e
 LEFT JOIN public.power_group AS pg ON pg.id = lr.power_group_id
 WHERE ei_ing.ident LIKE '30000000%'
   AND lr.valid_range @> CURRENT_DATE
-ORDER BY ei_ing.ident, ei_ed.ident;
+ORDER BY ei_ing.ident, ei_ed.ident, lr.percentage;
  influencing | influenced | percentage | power_group_ident | valid_from 
 -------------+------------+------------+-------------------+------------
  300000001   | 300000002  |      80.00 | PG0004            | 2023-01-01
diff --git a/test/sql/120_power_group_lifecycle.sql b/test/sql/120_power_group_lifecycle.sql
@@ -496,7 +496,7 @@ JOIN public.external_ident AS ei_ed ON ei_ed.legal_unit_id = lu_ed.id
 JOIN public.external_ident_type AS eit_ed ON eit_ed.id = ei_ed.type_id AND eit_ed.code = 'tax_ident'
 LEFT JOIN public.power_group AS pg ON pg.id = lr.power_group_id
 WHERE ei_ing.ident LIKE '30000000%'
-ORDER BY ei_ing.ident, ei_ed.ident;
+ORDER BY ei_ing.ident, ei_ed.ident, lr.percentage;
 
 -- Save Round 1 PG idents for reuse verification in Phase 4
 CREATE TEMP TABLE _round1_pgs AS
@@ -596,7 +596,7 @@ JOIN public.external_ident_type AS eit_ed ON eit_ed.id = ei_ed.type_id AND eit_e
 LEFT JOIN public.power_group AS pg ON pg.id = lr.power_group_id
 WHERE ei_ing.ident LIKE '30000000%'
   AND lr.valid_range @> CURRENT_DATE
-ORDER BY ei_ing.ident, ei_ed.ident;
+ORDER BY ei_ing.ident, ei_ed.ident, lr.percentage;
 
 -- ============================================================================
 -- PHASE 5: Pipeline Integration
