Ensure channels don't leak exception effects

The forward declarations cause `Exception` to be inferred - also,
`llrecv` is an internal implementation detail and the type of the
received item is controlled by generics, thus the ValueError raised
there seems out of place for the generic api.

Author: arnetheduck

lib/system/channels_builtin.nim

@@ -138,6 +138,8 @@
 ##   localChannelExample() # "Hello from the main thread!"
 ##   ```
 
+{.push raises: [], gcsafe.}
+
 when not declared(ThisIsSystem):
   {.error: "You must not import this module explicitly".}
 
@@ -390,7 +392,7 @@ proc llRecv(q: PRawChannel, res: pointer, typ: PNimType) =
   q.ready = false
   if typ != q.elemType:
     releaseSys(q.lock)
-    raise newException(ValueError, "cannot receive message of wrong type")
+    raiseAssert "cannot receive message of wrong type"
   rawRecv(q, res, typ)
   if q.maxItems > 0 and q.count == q.maxItems - 1:
     # Parent thread is awaiting in send. Wake it up.
@@ -455,3 +457,5 @@ proc ready*[TMsg](c: var Channel[TMsg]): bool =
   ## new messages.
   var q = cast[PRawChannel](addr(c))
   result = q.ready
+
+{.pop.}

tests/threads/tmembug.nim

@@ -12,14 +12,14 @@ var
 chan1.open()
 chan2.open()
 
-proc routeMessage*(msg: BackendMessage) =
+proc routeMessage*(msg: BackendMessage) {.raises: [], gcsafe.} = # no exceptions!
   discard chan2.trySend(msg)
 
 var
   recv: Thread[void]
   stopToken: Atomic[bool]
 
-proc recvMsg() =
+proc recvMsg() {.raises: [], gcsafe.} = # no exceptions!
   while not stopToken.load(moRelaxed):
     let resp = chan1.tryRecv()
     if resp.dataAvailable: