Skip to content

Build from source fails if certain special characters are in the users file path to project #78

@alexw24

Description

@alexw24

Describe the bug
Building Nimbus beacon node from source fails if a folder in the file path to the project has a space (or perhaps even other special characters, not sure didn't test) in it.

To Reproduce
Steps to reproduce the behavior:

  1. Platform details (OS, architecture): Mac OS 14.2.1 (23C71), apple silicon

  2. Branch/commit used: stable

  3. Commands being executed: make -j4 nimbus_beacon_node

  4. Relevant log lines:

path='vendor/NimYAML'; /Users/x/Ethereum Client/nimbus-eth2/vendor/nimbus-build-system/scripts/create_nimble_link.sh "$sm_path": /Users/x/Ethereum: No such file or directory
fatal: run_command returned non-zero status for vendor/NimYAML

As you can see, the second time the file path is mentioned in this log, the word "Client" got dropped.

Additional context
@tersec ran Shellcheck
Shellcheck output:

if [[ $(ls -1 *.nimble 2>/dev/null | wc -l) -gt 0 ]]; then
        ^------------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
              ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

For more information:
  https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
  https://www.shellcheck.net/wiki/SC2035 -- Use ./*glob* or -- *glob* so name...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions