fix: guard role-to-enum casts in models to prevent RangeDefect crashes

Fixes #21085

Add defensive bounds checks before converting Qt role integers to Nim enum roles across list-model data methods.

Return early when role is outside low(EnumRole)..high(EnumRole)
Prevent RangeDefect from bubbling through Qt event handlers during model/delegate lifecycle and tab switches
Apply the same protection pattern consistently across main, shared, onboarding, and keycard popup models
Includes the SectionModel hotspot and all other detected role-to-enum cast sites

Author: jrainville

src/app/modules/main/activity_center/model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, json, sequtils, strutils
 import ./item
 import ../../../../app_service/service/activity_center/dto/notification
@@ -60,10 +61,7 @@ QtObject:
   method rowCount*(self: Model, index: QModelIndex = nil): int = self.activityCenterNotifications.len
 
   method data(self: Model, index: QModelIndex, role: int): QVariant =
-    if not index.isValid:
-      return
-    if index.row < 0 or index.row >= self.activityCenterNotifications.len:
-      return
+    guardModelData(index, self.activityCenterNotifications.len, role, NotifRoles)
 
     let activityNotificationItem = self.activityCenterNotifications[index.row]
     let notificationItemRole = role.NotifRoles

src/app/modules/main/app_search/models/chat_search_model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables
 import chat_search_item
 import ../../../shared_models/model_utils
@@ -86,11 +87,10 @@ QtObject:
     }.toTable
 
   method data(self: Model, index: QModelIndex, role: int): QVariant =
-    if not index.isValid:
-      return
-    if index.row < 0 or index.row >= self.items.len:
-      return
+    guardModelData(index, self.items.len, role, ModelRole)
+
     let item = self.items[index.row]
+
     let enumRole = role.ModelRole
 
     case enumRole:

src/app/modules/main/app_search/models/location_menu_model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils
 
 import location_menu_item, location_menu_sub_item
@@ -38,13 +39,10 @@ QtObject:
     }.toTable
 
   method data(self: Model, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.items.len):
-      return
+    guardModelData(index, self.items.len, role, ModelRole)
 
     let item = self.items[index.row]
+
     let enumRole = role.ModelRole
 
     case enumRole:
@@ -78,4 +76,3 @@ QtObject:
 
   proc setup(self: Model) =
     self.QAbstractListModel.setup
-

src/app/modules/main/app_search/models/location_menu_sub_model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils, std/strformat
 
 import location_menu_sub_item
@@ -59,13 +60,10 @@ QtObject:
     }.toTable
 
   method data(self: SubModel, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.items.len):
-      return
+    guardModelData(index, self.items.len, role, SubModelRole)
 
     let item = self.items[index.row]
+
     let enumRole = role.SubModelRole
 
     case enumRole:
@@ -105,4 +103,3 @@ QtObject:
 
   proc setup(self: SubModel) =
     self.QAbstractListModel.setup
-

src/app/modules/main/app_search/models/result_model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils, std/strformat
 
 import result_item
@@ -67,13 +68,10 @@ QtObject:
     }.toTable
 
   method data(self: Model, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.resultList.len):
-      return
+    guardModelData(index, self.resultList.len, role, ModelRole)
 
     let item = self.resultList[index.row]
+
     let enumRole = role.ModelRole
 
     case enumRole:
@@ -130,4 +128,3 @@ QtObject:
 
   proc setup(self: Model) =
     self.QAbstractListModel.setup
-

src/app/modules/main/browser_section/bookmark/model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils, std/strformat
 
 import item
@@ -45,13 +46,10 @@ QtObject:
     }.toTable
 
   method data(self: Model, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.items.len):
-      return
+    guardModelData(index, self.items.len, role, ModelRole)
 
     let item = self.items[index.row]
+
     let enumRole = role.ModelRole
 
     case enumRole:
@@ -118,4 +116,3 @@ QtObject:
 
   proc setup(self: Model) =
     self.QAbstractListModel.setup
-

src/app/modules/main/browser_section/dapps/accounts.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils, std/strformat
 import ../../../../../app_service/service/wallet_account/service as wallet_account_service
 
@@ -47,13 +48,10 @@ QtObject:
     }.toTable
 
   method data(self: AccountsModel, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.items.len):
-      return
+    guardModelData(index, self.items.len, role, ModelRole)
 
     let item = self.items[index.row]
+
     let enumRole = role.ModelRole
 
     case enumRole:
@@ -91,4 +89,3 @@ QtObject:
 
   proc setup(self: AccountsModel) =
     self.QAbstractListModel.setup
-

src/app/modules/main/browser_section/dapps/dapps.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils, std/strformat, json
 import ./item
 
@@ -44,13 +45,10 @@ QtObject:
     }.toTable
 
   method data(self: DappsModel, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.items.len):
-      return
+    guardModelData(index, self.items.len, role, ModelRole)
 
     let item = self.items[index.row]
+
     let enumRole = role.ModelRole
     case enumRole:
     of ModelRole.Name:
@@ -84,4 +82,3 @@ QtObject:
 
   proc setup(self: DappsModel) =
     self.QAbstractListModel.setup
-

src/app/modules/main/browser_section/dapps/permissions.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, strutils, std/strformat
 
 type
@@ -39,11 +40,8 @@ QtObject:
     }.toTable
 
   method data(self: PermissionsModel, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
+    guardModelDataIndex(index, self.items.len)
 
-    if (index.row < 0 or index.row >= self.items.len):
-      return
     result = newQVariant(self.items[index.row])
 
   proc addItem*(self: PermissionsModel, item: string) =
@@ -68,4 +66,3 @@ QtObject:
 
   proc setup(self: PermissionsModel) =
     self.QAbstractListModel.setup
-

src/app/modules/main/chat_section/chat_content/input_area/urls_model.nim

@@ -1,3 +1,4 @@
+import app/modules/shared_models/model_utils
 import nimqml, tables, sequtils
 
 type
@@ -33,11 +34,7 @@ QtObject:
     }.toTable
 
   method data(self: Model, index: QModelIndex, role: int): QVariant =
-    if (not index.isValid):
-      return
-
-    if (index.row < 0 or index.row >= self.items.len):
-      return
+    guardModelData(index, self.items.len, role, ModelRole)
 
     let enumRole = role.ModelRole
 
@@ -93,4 +90,3 @@ QtObject:
 
   proc setup(self: Model) =
     self.QAbstractListModel.setup
-