test: replace xfail with light_client_7393 marker for nightly exclusion

Aligns with the convention introduced in #7412: tag the
LIGHT_CLIENT parametrize entry with a named, issue-tied marker and
exclude it from the reliability nightly via the workflow selector
instead of using xfail strict=False.

Single grep target for cleanup once #7393 lands.

- Register light_client_7393 marker in tests-functional/pytest.ini
- Update test-reliability.yml: -m "reliability and not light_client_7393"
- Replace xfail mark with light_client_7393 across 11 test files

Author: north661

.github/workflows/test-reliability.yml

@@ -57,7 +57,7 @@ jobs:
       run: |
         pytest --reruns 2 \
           -n auto \
-          -m "reliability" \
+          -m "reliability and not light_client_7393" \
           -c tests-functional/pytest.ini \
           --junit-xml=pytest_results.xml \
           --tb=short \

tests-functional/pytest.ini

@@ -24,4 +24,5 @@ markers =
     assets
     benchmark
     connector
-    ens
+    ens
+    light_client_7393: temporary marker for status-go#7393 filter subscription race; remove when fixed

tests-functional/tests/reliability/test_contact_request.py

@@ -13,7 +13,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/reliability/test_create_private_groups.py

@@ -11,7 +11,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/reliability/test_one_to_one_messages.py

@@ -11,7 +11,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/reliability/test_private_groups_messages.py

@@ -11,7 +11,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/test_wakuext_contact_requests.py

@@ -13,7 +13,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/test_wakuext_contact_verification.py

@@ -14,7 +14,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/test_wakuext_group_chats.py

@@ -10,7 +10,7 @@
     "waku_light_client",
     [
         pytest.param(False, id=FULL_NODE),
-        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+        pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
     ],
     indirect=True,
 )

tests-functional/tests/test_wakuext_message_reactions.py

@@ -25,7 +25,7 @@ async def receiver(self, async_backend_new_profile, waku_light_client):
         "waku_light_client",
         [
             pytest.param(False, id=FULL_NODE),
-            pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.xfail(reason="status-go#7393 filter subscription race", strict=False)),
+            pytest.param(True, id=LIGHT_CLIENT, marks=pytest.mark.light_client_7393),
         ],
         indirect=True,
     )